#529 Add support for dependency collection for Maven packages #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
changed the title
pombredanne
force-pushed
the
529-dependency-elements
branch
from
e198603 to
c7b2bbb
Compare
Codecov Report
@@ Coverage Diff @@
## develop #561 +/- ##
============================================
- Coverage 75.87% 64.23% -11.65%
============================================
Files 82 82
Lines 10493 10528 +35
============================================
- Hits 7962 6763 -1199
- Misses 2531 3765 +1234
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #561 +/- ##
===========================================
+ Coverage 75.87% 76.74% +0.86%
===========================================
Files 82 82
Lines 10493 10604 +111
===========================================
+ Hits 7962 8138 +176
+ Misses 2531 2466 -65
Continue to review full report at Codecov.
|
added 2 commits
June 13, 2017 16:11
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Use pymaven throughout for Maven POM parsing including collecting depdenencies * Use a patched subclass of pymaven with enhanced properties resolution and extract extra attributes that can serialize to a mapping * Update maven test expectations accordingly adding new tests for Package creation * made most maven-related tests data-driven and using plain JSON files Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
force-pushed
the
529-dependency-elements
branch
from
0ff7ab9 to
1c54a74
Compare
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including Pymaven, implement our own subClass from Pom class of Pymaven. This is to support pom location to get POM object. Use the getdependencies function to get dependencies details in POM parse of scancode toolkit.