-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show damage on repair items interaction point #4448
Conversation
Is it just me or is the main interaction point icon way bigger? |
I think it's supposed to be the shape of the wheel. We should additionally look for a good rubber mosaic texture, so we can actually show if the thing is damaged via material. |
I tried adding the damage textures to these in that ^ PR. But as usual when dealing with those things, it didn't work. Maybe @jokoho48 can check? I don't know anyone else who ever got these to work. |
Nvm. Works. I think we should this use additionally anyway though. |
// Interaction dots numbered 0..8, white to red. | ||
// Convert damage to number (rounding up), using 0.8 as max | ||
|
||
private _fileName = format [QPATHTOF(ui\damage_%1_ca.paa), ceil (linearConversion [0, 0.8, damage _target, 0, 8, true])]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be [0, 1, damage _target,
?
damage
goes from 0 to 1.
Also if you use ceil
here, damage like 0.0001 would show up as slightly damaged, when in reality it's nothing. maybe use round
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking was that damage above 0.8 always showed up as a destroyed wheel on a car, but that doesn't seem to be the case.
I like the rounding up as it will let you always see the damage between a damaged wheel and a perfect one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Great Work! Just some feedback shooting the wheel object does not change the state of the wheel so i can unload a full mag into wheel on the ground and nothing will happen. The only other item of feedback is that can this be expanded to on the vehicles as well. I have no idea which wheel is in bad shape |
Close #4333
Gives feedback on the damage of a repair item (wheel / track)
We don't have damaged models for these, so there is no way to tell a destroyed wheel from a good one.
Simple white->yellow->red scale; similar to medical
edit: dots are too big, I'll shrink em down to match the normal dot