Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disposable - switch NLAW to CBA disposable system and remove ace_disposable functionality #6955

Merged
merged 15 commits into from
Oct 17, 2019
Merged

Disposable - switch NLAW to CBA disposable system and remove ace_disposable functionality #6955

merged 15 commits into from
Oct 17, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Apr 21, 2019

When merged this pull request will:

@commy2 commy2 added this to the 3.12.7 milestone Apr 21, 2019
@commy2 commy2 requested a review from PabstMirror April 21, 2019 17:00
@PabstMirror
Copy link
Contributor

to maintain compatibility with CUP, we probably want to go in stages

  • move nlaw over to cba
  • then remove code after next cupdate

@jonpas
Copy link
Member

jonpas commented Apr 21, 2019 •
edited
Loading

Standard 2 version deprecation sounds the best to me.

EDIT: I guess we could do 1 version deprecation since our big updates are pretty separated now.

@commy2
Copy link
Contributor Author

commy2 commented Apr 21, 2019

I don't understand why we need to put the NLAW into CBA.

@PabstMirror
Copy link
Contributor

I mean make it compatible with cba_disposable (like how the configs are changed in this PR)
but leave the ace_disposable code for other addons to use

@commy2
Copy link
Contributor Author

commy2 commented Apr 21, 2019

All we have to do is to update CBA first, then CUP and at a later point ACE.

@commy2 commy2 mentioned this pull request Apr 25, 2019
Merged
5 tasks
@PabstMirror PabstMirror modified the milestones: 3.12.7, Ongoing Apr 27, 2019
@PabstMirror PabstMirror changed the title switch NLAW to CBA disposable system Disposable - switch NLAW to CBA disposable system May 6, 2019
@PabstMirror PabstMirror changed the title Disposable - switch NLAW to CBA disposable system Disposable - switch NLAW to CBA disposable system and remove ace_disposable functionality May 6, 2019
@commy2
Copy link
Contributor Author

commy2 commented Jul 31, 2019

Merge?

@commy2 commy2 modified the milestones: Ongoing, 3.13.0 Jul 31, 2019
@PabstMirror
Copy link
Contributor

this needs to be after cup

PabstMirror
PabstMirror approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cupdate is out

jonpas
jonpas requested changes Oct 17, 2019
View reviewed changes
docs/wiki/framework/disposables-framework.md Outdated Show resolved Hide resolved
docs/wiki/framework/disposables-framework.md Outdated Show resolved Hide resolved
docs/wiki/framework/disposables-framework.md Outdated Show resolved Hide resolved
docs/wiki/framework/disposables-framework.md Outdated Show resolved Hide resolved
@PabstMirror @jonpas
Apply suggestions from code review
e76aeba 
Co-Authored-By: jonpas <jonpas33@gmail.com>
@commy2 commy2 merged commit 2a6d555 into master Oct 17, 2019
@commy2 commy2 deleted the cbaDisposable branch October 17, 2019 18:57
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp3 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
area/compatibility
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@commy2 @PabstMirror @jonpas