-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical Vitals - Add SPO2 #9360
Conversation
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
My group is currently playing with the PR merged, problems with respawn and trying to fully heal. Also want more testing on HR. |
@LinkIsGrim Don't you think it's slightly OP to reset oxygen demand when a unit is fully healed, especially if #9714 is going to considered? |
No. It's a full heal, and resetting oxygen demand to 0 won't change an/ae reserves. It will just be recalculated to an accurate value a few frames later anyway. |
Apart from that, what else needed fixing? |
Maybe some balancing, and we have a compatibilty issue with grad trenches currently, or rather their stamina bug |
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Seems to be working great, no more passing our from a 30 second sprint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oxygen saturation will tend towards 100 on most maps, but the functionality is fine. I think we should get this merged and tweak the math as necessary.
Do we want to merge this now or wait for another release? |
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When merged this pull request will:
There are a lot of magic numbers, this is mostly an approximation as there is no way to properly simulate this without simulating the whole human.
Going to do more testing and maybe value tweaking, but I don't plan on adding anything more to this PR. I think #8929 should be fixed up and updated to use this system
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.