[Moose] ConfigOB - grepping the boolean config settings using ConfigOB #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasbrossard
requested changes
Oct 15, 2019
| ) | ||
| && (NeuroDB::DBI::getConfigSetting($this->{dbhr},'createCandidates')) | ||
| my $configOB = $this->{'configOB'}; | ||
| if (!NeuroDB::MRI::subjectIDExists($subjectIDsref->{'CandID'}, $this->{dbhr}) |
There was a problem hiding this comment.
No need to instantiate $configOB again: it was already defined on line 1585. Also, the definition of $createCandidates should go here instead of further up.
| RETURN: (boolean) 1 if create_nii is set to Yes in the Config module, 0 otherwise | ||
|
|
||
| =cut | ||
| sub getCreateNii { |
There was a problem hiding this comment.
I think it would be a good idea to have a private function getBoolean that the other methods would call instead of "hardcoding" the logic inside each method. What do you think?
Oh and here's how you declare/used a private function:
my $privatePrintMethodRef = sub {
my($arg) = @_;
print "$arg.\n";
};
.
.
.
sub myPublicSayHelloMethod {
$myPrivatePrintMethodRef->('Hello');
}
|
@nicolasbrossard Thank you for the review! I integrated all your comments in the last commit. Please re-review :) |
nicolasbrossard
requested changes
Oct 16, 2019
|
@nicolasbrossard Thank you! Your suggestions have been integrated in the last commit. Please re-review. |
nicolasbrossard
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, all boolean Config options are queried using the
ConfigOBinstead of the function inDBI.pm.This fixes partly