Refactor remaining array configs to use ConfigOB instead of the DBI library #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cmadjar
force-pushed
the
refactor_remaining_array_configs
branch
from
40b5542
to
b48bcde
Compare
|
@nicolasbrossard ready for another review. Thank you! |
nicolasbrossard
requested changes
Jun 17, 2022
|
@nicolasbrossard I believe I took care of all your comments. Thanks! |
nicolasbrossard
requested changes
Jun 17, 2022
|
@nicolasbrossard good catch! Should be fixed in the last commit |
nicolasbrossard
requested changes
Sep 1, 2022
|
|
||
| Get the bids_acknowledgments_text Config setting | ||
|
|
||
| RETURN: an array (possibly empty) of the acknowledgment text to use for a BIDS dataset |
There was a problem hiding this comment.
I don't think this method returns an array but a string. Also, when you do not define an acknowledgment text, this method returns undef (not the empty string ''). Is this the intended behavior?
|
|
||
| Get the bids_readme_text Config setting | ||
|
|
||
| RETURN: an array (possibly empty) of the README text to use for a BIDS dataset |
There was a problem hiding this comment.
Same comment as for the acknowledgment text.
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 20 days. |
nicolasbrossard
approved these changes
Feb 17, 2023
zaliqarosli
pushed a commit
to zaliqarosli/Loris-MRI
that referenced
this pull request
Mar 9, 2023
…ibrary (aces#770) * use configOB for array configs * use configOB for minc_to_bids script * fix bug in delete script * fix bugs with new perl * use array for some bids config * bug fix * fix pod error + Nic's comment * take care of Nic's comments * recreate markdown files * correct documentation of grep_FileIDs_to_deface in run_defacing_script * Nic's review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the refactoring of the database config queries to use ConfigOB instead of the DBI library directly.
This resolves #465