imaging_uploader

[LeighMac]

Tasks:

• Review issues from previous release testing

Documentation Tasks

• Update test plans
• Review/update module READMEs (Interactions, configurations, permissions, widgets, …)
• Check user help content for accuracy and formatting (front end)

Testing Tasks

• Follow test plan (SEPARATE TICKETS)
• Check if automated tests are up to date - seems ok but need to run them
• Make sure RB is complete
• phase 2 (?):
  • backend access: make sure the visit label in the browse tab reflects the Visit_label column in the session table for any Active candidate.
  • Test upload with Phantom = No with:
    • A candidate that has Active set to 'N' in the candidate table
    • A session that has Active set to 'N' in the session table

Standards: Make sure the latest standards are upheld

Check the boxes below only if the statements are true !

• No ajax dir
  • has ajax dir
• Data framework implemented
  • main class extends \NDB_Menu_Filter_Form
• React (no templates directory)
• Widgets (If module contains candidate information, at least 1 widget is implemented for the candidate profile module)

Issues

Newly reported issues

• [imaging_uploader] Loris-MRI - imaging pipeline fails  #8623
• [imaging_uploader] update test plan #8609
• [imaging upload] no selection of violated scans #8665
• [imaging uploader] When no connection to db in profile, uploads indefinitely #8666
• [imaging uploader] error 500 when uploading file bigger than 1 GB #8707

Previously reported issues (that are still relevant)

• [Imaging Uploader] Scan stays in 'Processing' state forever #6621
• [Imaging Uploader] System says upload was successful but it was not #7719
• [Imaging Uploader] Handle form upload errors #6873
• [imaging uploader] Combine the two columns with number of MINC into one column only #4920 (some modifications on UI, but stale issue)
• Improve error messages of ServerProcessesManager for the imaging uploader #5163 (stale)
• [Server Process Manager] MRI code path should not be mandatory #4750 (stale)
• [Server process manager] do NOT delete process files if exit code is not 0 for OTHER THAN MRI_Upload #5048
• Do front-end validation of file sizes (and reject when too big) #5046 (stale, issue is resolved. However, listed here because the process order could be better. This issue is still relevant, but a new issue should be raised instead. Process order right now = upload the file THEN look for the file size, which could take a long time)
• MriConfigFile is undocumented in dicom-archive/README.md #4011 (stale, doc missing, e.g. config MriConfigFile: can find Config changes but no doc on LORIS or LORIS-MRI repo)
• REST or other such API for data upload? #3022 (stale, API for data upload?)

Candidate release testing issues

• [imaging_uploader] Visit Label populated from the entire end of the file name #8803
• [imaging_uploader] A file that exceeds the max upload size doesn't give swal error warning #8807
• [imaging_uploader] Test plan item #14 fails "Ensure that column MR Scan Done is set to Y" #8812
• [imaging_uploader] Test plan item 19 fails: server processes manager entry doesn't update with error #8822
• [imaging_uploader] Test plan item 22 fails: Wrong detailed log message shown #8823

Comments

• insert comments here

Status

• Testing COMPLETE
• Partially Tested
• Could Not Test (please specify reasons in comment)

[sruthymathew123]

Hi @zaliqarosli, I couldn't test this module completely as it requires a valid scan. Backend access and loris-mri pipeline set up needed to test things mentioned from Step 6 onwards. Let me know if you can have a look or something I can do to complete testing.

[zaliqarosli]

@sruthymathew123 can you complete the tasks in the description of this issue above and i'll test items 6-23 in the test plan

[sruthymathew123]

@zaliqarosli Sorry for the late update here. I tested upto 6 during the testing round.

[zaliqarosli]

hi @sruthymathew123 please review the tasks list in the description on this issue and complete them. there are some checkboxes that haven't been ticked. i.e. you can still do 1. "Review/update module READMEs (Interactions, configurations, permissions, widgets, …)" and 2. "Check user help content for accuracy and formatting (front end)". and do the rest