[EEG] Task to property prefix for additional events table

[regisoc]

Brief summary of changes

Rename the additional events' table attributes prefix from Task to Property to match BIDS naming.

Linked to LORIS-MRI 900

[christinerogers]

This could technically be normalized further since PropertyName is a column name in an events.tsv file (and in the json etc), right?
Multiple events will have the same PropertyName (with each their own PropertyValue)
not sure if it's been considered / worth it @laemtl

[christinerogers]

the name of the table should change too @regisoc @laemtl @jeffersoncasimir yes?
literally physiological_event_additional would be more accurate I think

[laemtl]

I am hesitant on that one since the original table name for event is physiological_task_event (which started the confusion :))

[laemtl]

See BIDS doc, where they also refer to task events

[christinerogers]

i agree that is the source of the confusion :)

[christinerogers]

@jeffersoncasimir let me know if i missed something in flagging these, thanks

[laemtl]

This could technically be normalized further since PropertyName is a column name in an events.tsv file (and in the json etc), right? Multiple events will have the same PropertyName (with each their own PropertyValue) not sure if it's been considered / worth it @laemtl

This has been discussed and I think I agree that this would be a better approach for extensibility/future improvements.
@regisoc any thoughts?

[regisoc]

We discussed this and yes, this approach allows for any potential additional property.
There will be repetition for each PhysiologicalTaskEventID (if I remember correctly, every line in _event.tsv file) only if the property is initialized. So, if there is very few data on additional columns, that is taken care off.
I think this is the most extensive and permissive way because we can add any new column name in _event.tsv file as a single line in this table, which translate with (task event ID, name of the additional property for this task event, value of the additional property for this task event).

[christinerogers]

lgtm with Laetitia and Jefferson's blessing. thanks @regisoc for being on top of this so quickly

[christinerogers]

@driusan i think this is ready to merge.
cc @laemtl