Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EEG] Task to property prefix for additional events table #8432

Merged
merged 1 commit into from
Mar 14, 2023
Merged

[EEG] Task to property prefix for additional events table #8432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SQL/0000-00-05-ElectrophysiologyTables.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,8 @@ CREATE TABLE `physiological_task_event` (
CREATE TABLE `physiological_task_event_opt` (
`ID` int(10) unsigned NOT NULL AUTO_INCREMENT,
`PhysiologicalTaskEventID` int(10) unsigned NOT NULL,
`TaskName` varchar(50) NOT NULL,
`TaskValue` varchar(255) NULL,
`PropertyName` varchar(50) NOT NULL,
`PropertyValue` varchar(255) NULL,
PRIMARY KEY (`ID`),
CONSTRAINT `FK_event_task_opt`
FOREIGN KEY (`PhysiologicalTaskEventID`)
Expand Down
4 changes: 2 additions & 2 deletions SQL/New_patches/2022-11-22-eeg-additional-events-table.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
CREATE TABLE `physiological_task_event_opt` (
Copy link
Contributor

@christinerogers christinerogers Mar 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name of the table should change too @regisoc @laemtl @jeffersoncasimir yes?
literally physiological_event_additional would be more accurate I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am hesitant on that one since the original table name for event is physiological_task_event (which started the confusion :))

Copy link
Contributor

@laemtl laemtl Mar 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See BIDS doc, where they also refer to task events

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree that is the source of the confusion :)

`ID` int(10) unsigned NOT NULL AUTO_INCREMENT,
`PhysiologicalTaskEventID` int(10) unsigned NOT NULL,
`TaskName` varchar(50) NOT NULL,
`TaskValue` varchar(255) NULL,
`PropertyName` varchar(50) NOT NULL,
`PropertyValue` varchar(255) NULL,
PRIMARY KEY (`ID`),
CONSTRAINT `FK_event_task_opt`
FOREIGN KEY (`PhysiologicalTaskEventID`)
Expand Down