This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Selective persistent termination logs #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We should preserve the termination log of tasks that are supposed to be long-running and not terminated during the entire application lifecycle (e.g., server apps), when there are many volatile tasks continuously spawned and destroyed, regardless of the history limit.
achimnol
added a commit
to aio-libs/aiomonitor
that referenced
this pull request
Apr 24, 2023
* Add optional task creation stack chains to 'where' command (achimnol#1) * feat: Rewrite ps command to provide more concise view (achimnol#2) * feature: print numbers of total tasks when executing `ps` (achimnol#3) * Adopt `prompt_toolkit` and support concurrent clients (achimnol#4) * feat: Migrate to Click-based command line interface (achimnol#5) * fix: Reimplement console command (achimnol#6) * Support auto-completion of commands and arguments (achimnol#7) * Implement cancellation chain tracker (achimnol#8) * New commands: - `ps-terminated` (`pt`, `pst`) - `where-termianted` (`wt`) * New options: - `ps`, `pt`: `-f`, `--filter` to search task logs by their names and coroutine summary strings - `aiomonitor.Monitor` now has the history limit option (default: 1000) * Selective persistent termination logs (achimnol#9) - We should preserve the termination log of tasks that are supposed to be long-running and not terminated during the entire application lifecycle (e.g., server apps), when there are many volatile tasks continuously spawned and destroyed, regardless of the history limit. * fix: Support passing `name` and `context` kwarg to `create_task()` (achimnol#10) * fix: Regression in Python 3.10 due to achimnol#10 (achimnol#11) --------- Co-authored-by: Kyujin Cho <thy2134@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it will preserve the termination log of any asyncio task wrapped with the
preserve_termination_logdecorator indefinitely, regardless of the history limit.