Backport aiomonitor-ng #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement creation/cancellation traceback chain using a custom task factory * Add taskgroup example with aiotools
* NOTICE: If this fork's improvements are accepted by the original authors of aiomonitor, it will be merged back to the original project. The purpose of fork is to keep up with the release cycle of Backend.AI.
- This will help us to inspect thousands of tasks - Add more columns to assist debugging
* feat: Adopt `prompt_toolkit` to serve concurrent telnet connections * feat: Implement our own minimal telnet client as `aiomonitor.telnet` - This will make `aiomonitor.cli` to work seamlessly with `prompt_toolkit`. - ref: https://github.com/jquast/telnetlib3/
* feat: Migrate to Click-based command line interface * fix: Override click's stdout/stderr with per-connection stdout * feat: Implement the exit command
* fix: Support async Click command handlers using events
* fix: Reimplement console proxy
- It uses an inner `prompt_toolkit.PromptSession()` to handle the user
inputs of the aioconsole prompt.
* New commands:
- `ps-terminated` (`pt`, `pst`)
- `where-termianted` (`wt`)
* New options:
- `ps`, `pt`: `-f`, `--filter` to search task logs by their names and
coroutine summary strings
- `aiomonitor.Monitor` now has the history limit option (default: 1000)
* Prevent memory leak of the termination logs using memray and tracemalloc
- The memory leaked by `myself = asyncio.current_task()` in the
coroutine wrapper.
- Also use the weak value for task creation chains to ensure gc
target tasks.
- We should preserve the termination log of tasks that are supposed to be long-running and not terminated during the entire application lifecycle (e.g., server apps), when there are many volatile tasks continuously spawned and destroyed, regardless of the history limit.
|
LGTM! 🤠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check out what's added in #333! 😉