Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for acis_thermal_check #27

Merged
merged 10 commits into from
May 21, 2020
Merged

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented May 16, 2020

Description

This PR implements documentation for acis_thermal_check, including how to run an acis_thermal_check application, develop a new one, and test it.

A compiled example of the documentation is present at http://cxc.harvard.edu/acis/acis_thermal_check.

This PR also cleans up some of the usage text in the ArgumentParser object used by acis_thermal_check applications.

Testing

  • Passes unit tests on MacOS

@jzuhone
Copy link
Member Author

jzuhone commented May 18, 2020

@taldcroft I don't know if you want to have a look at the documentation linked above. The ACIS team has already reviewed it and approves.

@swolk
Copy link

swolk commented May 20, 2020

From an FD POV this looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants