Write .hist files to --outdir directory #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzuhone
reviewed
Oct 21, 2021
acis_thermal_check/state_builder.py
Outdated
| def __init__(self, interrupt=False, | ||
| backstop_file=None, | ||
| nlet_file=None, | ||
| outdir = None, |
There was a problem hiding this comment.
Suggested change
| outdir = None, | |
| outdir=None, |
jzuhone
reviewed
Oct 21, 2021
| proc = self._setup_proc_and_logger(args) | ||
|
|
||
| # Record the selected state builder in the class attributes |
There was a problem hiding this comment.
Did it not work if you didn't move this after _setup_proc_and_logger?
There was a problem hiding this comment.
I moved it because I wanted to be sure that the output directory was created before Backstop History was instantiated. All regression tests passed.
jzuhone
reviewed
Oct 21, 2021
acis_thermal_check/utils.py
Outdated
| @@ -428,6 +428,7 @@ def make_state_builder(name, args): | |||
| state_builder = builder_class(interrupt=args.interrupt, | |||
| backstop_file=args.backstop_file, | |||
| nlet_file=args.nlet_file, | |||
| outdir = args.outdir, | |||
There was a problem hiding this comment.
Suggested change
| outdir = args.outdir, | |
| outdir=args.outdir, |
jzuhone
approved these changes
Oct 21, 2021
This was referenced Oct 22, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modification to write the assembled history into the model --outdir directory.
This is in addition to the changes included in the #41
and acisops/backstop_history#20 PR's in that as of the creation of this PR the others
have not yet been put into production.
Testing
Fixes #