Update for SCS-106 change and new power commands #20

Gregg140 · 2021-09-30T16:42:42Z

Description

Recently, SCS-106 was updated to leave 3 FEPs on rather than no FEPs on.
SCS-106 is run as part of the SCS-107 sequence.

Therefore thermal model history assembly requires that this change be reflected
in any shutdown: both science-only shutdowns as well as Full Stops. Also, the
ACIS Team recently added new power commands which have to be handled by Backstop History.

These were the drivers for the release of this version of Backstop History.
Several changes had been underway for some time and are incorporated in this release.

Testing

[x ] Passes unit tests on MacOS, linux, Windows (at least one required)
Functional testing

Fixes #

…otes

jzuhone · 2021-10-18T16:47:49Z

backstop_history/BackstopHistory.py

@@ -330,7 +246,7 @@ def get_continuity_file_info(self, oflsdir):

            # Read the first line...the path to the continuity load. The
            # continuity path in the file is hardwired to a /data/acis path,
-            # independent of user-specified `oflsdir` (e.g.
+            # independent of user-specified `oflsdir` (e.g.BackstopHistory.py


This got copied in somehow

jzuhone · 2021-10-18T16:49:40Z

backstop_history/BackstopHistory.py


+        # Convert tbegin to cxcsec if necessary
+        if type(tbegin) is str:


Suggested change

if type(tbegin) is str:

if isinstance(tbegin, str):

jzuhone · 2021-10-18T16:50:47Z

backstop_history/BackstopHistory.py

+            event_list = self.Find_Events_Between_Dates(self.master_ToFC, self.end_event_time)
+
+            # ....and if there are events to process.......
+            if event_list != []:


Suggested change

if event_list != []:

if len(event_list) > 0:

jzuhone · 2021-10-18T16:51:46Z

backstop_history/BackstopHistory.py

-               being reviewed this week.  This routine can be called multiple
-               times - tacking continuity loads to the start of the "master list"
+        # If this is a legal maneuver, process it
+        if pitch != 0.0:


A bit nervous about a floating-point comparison like this. Is there a way to do it differently?

Other LR code (history-files.pl) explicitly sets the pitch to 0.0 in the NLET file if the user
did not or could not specify the 4 quaternions. The 4 Quaternion entries are set to a bogus value as well. Since we know the pitch ought not get below 45, and 0.0 is not possible then
explicitly setting will work. It is converted from a string value - not a calculation.

Can you make a comment to this effect here then?

Certainly I added the explanation.

jzuhone · 2021-10-18T16:53:42Z

backstop_history/BackstopHistory.py

@@ -1248,7 +1155,7 @@ def Trim_bs_cmds_Before_Date(self, trim_date, cmd_list):
    #             Continuity text files of each load starting with the
    #             base load, and record the continuity information in a numpy array
    #
-    #                 INPUTS: base_dir  (e.g. '/data/acis/LoadReviews/2017/')
+    #                 INPUTS: base_dir  (e.g. '/data/acis/LoadReviews/2017/')2021:179:04:00:02.313


It looks like this shouldn't have been added here

jzuhone

So I made a few suggested changes (some of which you can actually just add as commits by hitting the button below if you agree with them).

The other thing I want to mention is that it's not clear that using astropy.time.Time and the cxcsec property is always guaranteed to be in sync with the CxoTime class, which is what we use elsewhere in the code. Tom may have a better idea about this since he's a developer for both.

I remember (I think) that one motivation for this was to try to run things outside of ska and in a regular python environment, but it seems to me that it may just be easier to install CxoTime in said environment by itself, because I don't think it has any other ska dependencies.

So for those reasons, my preference would be to use CxoTime for consistency across packages.

Gregg140 · 2021-10-18T18:46:23Z

Regarding the use of Astropy Time, the difference and rationale was discussed in detail and approved in the PR for another tool where Astropy Time was used:

acisops/lr#27

All of that rationale applies here, with the exception of the time needed to load ska. I now need to use the NLET system for applications outside of thermal models - for example in calculating recovered science time obtained from ECS measurements that are below 5000 second in exposure time: non-load events can change the actual recovered science time. This is not a ska app and should be possible to run anywhere on any machine, including home machines and MIT without requiring anything other than python3 and Astropy.

The subtle difference between Cxotime and Astropy time was mentioned in that PR. I researched the Github issues and found the issue entry regarding this difference. Regression testing shows that there is no difference in time stamps in the gold vs new states.dat and temperatures.dat files.

For lighter, more portable, faster executing code which does not require the parsing and numerous capabilities of CxoTime (only converting known formats yday <-> cxcsec) I prefer to use Astropy Time.

jzuhone · 2021-10-18T19:03:12Z

Regarding the use of Astropy Time, the difference and rationale was discussed in detail and approved in the PR for another tool where Astropy Time was used:
acisops/lr#27

This is not a ska app and should be possible to run anywhere on any machine, including home machines and MIT without requiring anything other than python3 and Astropy.

I guess the difference here is that this tool needs to interact directly with Ska packages (even if it could be used elsewhere), but the case in acisops/lr#27 didn't.

The subtle difference between Cxotime and Astropy time was mentioned in that PR. I researched the Github issues and found the issue entry regarding this difference. Regression testing shows that there is no difference in time stamps in the gold vs new states.dat and temperatures.dat files.

Right, I'm just worried that this won't always be true, though it may be true now. I wouldn't be surprised if cxcsec was eventually deprecated in astropy.time in favor of cxotime, since I suspect the latter will (maybe) eventually be turned into a standalone package that doesn't require installation via the Ska method.

I'm not going to make this a blocker, but it's something we need to keep in mind for the future.

jazan12 · 2021-10-18T19:03:24Z

backstop_history/BackstopHistory.py

@@ -1248,7 +1155,7 @@ def Trim_bs_cmds_Before_Date(self, trim_date, cmd_list):
    #             Continuity text files of each load starting with the
    #             base load, and record the continuity information in a numpy array
    #
-    #                 INPUTS: base_dir  (e.g. '/data/acis/LoadReviews/2017/')
+    #                 INPUTS: base_dir  (e.g. '/data/acis/LoadReviews/2017/')2021:179:04:00:02.313


Is that trailing timestamp intentional?

@Gregg140 fixed that already

Already fixed

jazan12 · 2021-10-18T19:04:28Z

backstop_history/BackstopHistory.py

-    # write_back_chain_to_pickle - Given a backchain, write the contents of the
-    #                              backchain to a pickle file. If this is ACIS format
-    #                              the full path to the OFLS directory is written out.
+    #                    Attribute Sets and Gets


Missing description?

Comment explained in email - it's just a comment showing that the location of any set and get methods are here

jazan12 · 2021-10-18T19:05:59Z

backstop_history/Release_Notes_V3.0.0.txt

+The previous version of Backstop History and acis_thermal_check (ATC) placed a major loop
+inside the ACISStateBuilder class of state_builder.py wherein ATC was controlling the assembly
+of a backstop history.  Presently, ATC detects when to end the backchaining and also assesses 
+the types of loads (Normal, TOO, SCSD-107 Full Stop) for each load in the backchain. 


SCSD --> SCS, and also there should be a comma after 107

jazan12 · 2021-10-18T19:06:15Z

backstop_history/Release_Notes_V3.0.0.txt

+inside the ACISStateBuilder class of state_builder.py wherein ATC was controlling the assembly
+of a backstop history.  Presently, ATC detects when to end the backchaining and also assesses 
+the types of loads (Normal, TOO, SCSD-107 Full Stop) for each load in the backchain. 
+These fucntions belong inside Backstop History so that All ATC does is request an assembled 


functions misspelled

jazan12 · 2021-10-18T19:06:56Z

backstop_history/Release_Notes_V3.0.0.txt

+necessary command sequences (e.g. LTCTI's, Maneuvers, SCS-107 etc.) a CR*.backstop.hist 
+file is written out to the directory of the load under review: the root of the file name
+being the same as the review load CR*.backstop file, with ".hist" appended. This .hist file 
+is writtern out in CR*.backstop format and can be run through a models.  This provides


model singular

jazan12 · 2021-10-18T19:07:36Z

backstop_history/Release_Notes_V3.0.0.txt

+logger message.  The level of verbosity is captured by ATC and passed to the ACIS state
+builder.
+
+Also includes changes John made which ake the role of the run_start argument much more clear.


ake --> make

jazan12 · 2021-10-18T19:09:35Z

backstop_history/LTCTI_RTS.py

-    processed and converted to a dict in the SKA.parse format. Each dict is appended
-    to an output list.
+"""
+    These functions allows the user to convert a FOT, ACIS, LTCTI, RTS file, along with


allow singular

jazan12

Looks good Gregg. Only small typos and maybe some missing description flagged by me. Check it out and proceed.

Update for SCS-106 change and new power commands

70724b3

Gregg140 requested review from cegrant, jazan12 and jzuhone September 30, 2021 16:44

ggermain added 2 commits September 30, 2021 12:45

Update for SCS-106 change and new power commandsPR added to release n…

8aa1372

…otes

Typos and cleaned up diagnostics

ccbee9e

jzuhone reviewed Oct 18, 2021

View reviewed changes

jzuhone requested changes Oct 18, 2021

View reviewed changes

Updates based upon Johns comments

568647a

jazan12 reviewed Oct 18, 2021

View reviewed changes

jazan12 approved these changes Oct 18, 2021

View reviewed changes

Updates based upon Jacks comments

b4bb3d1

jzuhone approved these changes Oct 18, 2021

View reviewed changes

Gregg140 merged commit c90701e into master Oct 18, 2021

This was referenced Oct 18, 2021

Update acisops/backstop_history to 1.5.0 sot/skare3#719

Closed

Update acisops/acis_thermal_check to v3.7.0 sot/skare3#720

Closed

2021.14 sot/skare3#723

Merged

Gregg140 mentioned this pull request Oct 21, 2021

Write .hist files to --outdir directory acisops/acis_thermal_check#42

Merged

1 task

Gregg140 mentioned this pull request Oct 21, 2021

Use cr backstop files #21

Merged

1 task

This was referenced Oct 22, 2021

Update acisops/acis_thermal_check to 3.7.0 sot/skare3#724

Closed

Update acisops/acis_thermal_check to 3.7.1 sot/skare3#725

Closed

Update acisops/backstop_history to 1.5.1 sot/skare3#726

Closed

javierggt mentioned this pull request Mar 30, 2022

2022.3 sot/skare3#812

Merged

javierggt mentioned this pull request May 18, 2022

2022.5 (closed) sot/skare3#850

Closed

javierggt mentioned this pull request Aug 3, 2022

2022.5 sot/skare3#899

Merged

javierggt mentioned this pull request Jun 6, 2023

Update acisops/backstop_history to v3.2.1 sot/skare3#1111

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update for SCS-106 change and new power commands #20

Update for SCS-106 change and new power commands #20

Gregg140 commented Sep 30, 2021

jzuhone Oct 18, 2021

Gregg140 Oct 18, 2021

jzuhone Oct 18, 2021

Gregg140 Oct 18, 2021

jzuhone Oct 18, 2021

Gregg140 Oct 18, 2021

jzuhone Oct 18, 2021

Gregg140 Oct 18, 2021

jzuhone Oct 18, 2021

Gregg140 Oct 18, 2021

jzuhone Oct 18, 2021

Gregg140 Oct 18, 2021

jzuhone left a comment

Gregg140 commented Oct 18, 2021

jzuhone commented Oct 18, 2021

jazan12 Oct 18, 2021

jzuhone Oct 18, 2021

Gregg140 Oct 18, 2021

jazan12 Oct 18, 2021

Gregg140 Oct 18, 2021

jazan12 Oct 18, 2021

Gregg140 Oct 18, 2021

jazan12 Oct 18, 2021

Gregg140 Oct 18, 2021

jazan12 Oct 18, 2021

Gregg140 Oct 18, 2021

jazan12 Oct 18, 2021

Gregg140 Oct 18, 2021

jazan12 Oct 18, 2021

Gregg140 Oct 18, 2021

jazan12 left a comment


		# Convert tbegin to cxcsec if necessary
		if type(tbegin) is str:

Update for SCS-106 change and new power commands #20

Update for SCS-106 change and new power commands #20

Conversation

Gregg140 commented Sep 30, 2021

Description

Testing

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jzuhone left a comment

Choose a reason for hiding this comment

Gregg140 commented Oct 18, 2021

jzuhone commented Oct 18, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jazan12 left a comment

Choose a reason for hiding this comment