Temporarily disable the inclusion of gratings moves states #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, kadi was updated to include grating moves in the gratings states (sot/kadi#210). This changes not only the values of the grating states in the
acis_thermal_check
answer tests (expected) but also the values of the thermal propagation (unexpected, since the ACIS thermal models do not depend on grating state). The differences are very small (~0.1-0.2 degC) but are under investigation (a preliminary hypothesis suggests that the reason is that the JSON model spec files used for testing useevolve_method = 1
).For the time being, this PR disables the inclusion of grating moves states in
acis_thermal_check
, which ensures that the regression tests pass. This is ok from the perspective of operations assuming that the above hypothesis proves correct (since the flight versions of these files useevolve_method = 2
) and since the actual temperature does not depend on gratings moves.The tests and model specification files will be updated to accomodate the new gratings moves states at a date in the near future.
Testing