Make changes for grating move duration (again) #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c2cc9f6.
|
I thought they still hadn't updated their tests for this but I'm fine to track that by the skare3 masters testing failures until those failures go away. |
|
Yes, I'm sending separate email now to ACIS ops. |
2 tasks
This was referenced Oct 25, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a re-do of #205, which was discovered to break ACIS ops tests. This is pending update of their tests.
Per discussion on slack ("looking at the commands associated with the letg state key" in ska-dev on Aug 12), add a new intermediate state to the grating states to indicate the movement time between INSR and RETR.
Testing