Check and plot the ACIS FP safety planning limit, support the new ACIS FP model

[jzuhone]

Description

This PR does three things:

1. Add support for plotting the ACIS safety planning and caution limits on one of the model plots (adjusts the y-axis limit for this plot so they can be seen).
2. Add support for checking violations of the ACIS safety planning limit. A test has been added for this functionality.
3. Support the new ACIS FP thermal model which can incorporate the Earth phase in its Earth solid angle calculation (Adjust earthshine effect based on Earth phase sot/xija#117)

Interface impacts

The ACIS FP thermal model web pages will now show lines for the planning and caution safety limits on one of the plots, and any violations of the planning limit will now be reported.

Testing

Unit tests

• Mac
• Linux

Functional tests

• Checked that the web pages are produced as expected
• Artificially lowered limits to produce a violation, checked that it was in the expected location

[jazan12]

Looks good.

[Gregg140]

Question:
In acisfp_check.py you have (line 50):

        "planning.warning.high": "planning_hi",

In MAY0922A_viol.json you have (line 3,4,5):
"limits": {
"planning_hi": -97.0
},

And back in acisfp_check.py you have (lines 283 to 295):

---------------------------------------------------------------

    # Planning - Collect any -84 C violations. These are load killers
    # ---------------------------------------------------------------

    hi_viols = self._make_prediction_viols(
        times, temp, load_start, self.limits["planning_hi"].value,
        "planning", "max")
    viols = {"hi":
                 {"name": f"Planning High ({self.limits['planning_hi'].value} C)",
                  "type": "Max",
                  "values": hi_viols}
             }

How/where did self.limits["planning_hi"].value get set to 84?

[jzuhone]

Hi @Gregg140,

How/where did self.limits["planning_hi"].value get set to 84?

This is taken from the limits directory in the JSON file. In the test JSON file MAY0922A_viol.json we override it to fake a violation and test the violation reporting functionality.

[Gregg140]

Ok thanks.

[Gregg140]

Looks good