2022.6 #860

javierggt · 2022-05-31T10:39:17Z

ska3-flight 2022.6

This PR includes:

acis_thermal_check changes approved in FSDS-36.
Changes in sparkles and proseco with a modified guide-count calculation for dynamic background.
Various fixes for RedHat 8.

The full set of code has also been fully tested on Redhat 8 and at this time we would also like to request approval to use the ska3-flight environment on RHEL8 systems for operational use as those systems become available.

Interface Impacts:

None

Testing:

The latest release candidate (2022.6rc3) is installed in /proj/sot/ska3/test on HEAD and GRETA, and is available for testing from the usual channels:

conda create -n ska3-flight-2022.6rc3 --override-channels \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/flight \
  -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/test \
  ska3-flight==2022.6rc3

Test results

skare3 dashboard and test result password at https://icxc.cfa.harvard.edu/aspect/skare3_dash_cred.txt

HEAD.
GRETA.

Release candidate tests:

Additional Functional Tests:

Starcheck
Starcheck has no unit tests. A simple single-load regress diff confirms that the only difference between the flight output and the test output run on RHEL8 is the location of the starcheck data (in the test directory in the test).

jeanconn-owen-v> diff -u jun0622a_flight.txt jun0622a_rhel_test.txt
--- jun0622a_flight.txt	2022-06-03 12:54:30.494613260 -0400
+++ jun0622a_rhel_test.txt	2022-06-03 12:56:09.810119000 -0400
@@ -1,18 +1,18 @@
  ------------  Starcheck 13.15.1    -----------------
- Run on Fri Jun  3 12:54:28 EDT 2022 by jeanconn from fido.cfa.harvard.edu
- Configuration:  Using AGASC at /proj/sot/ska3/flight/data/agasc/proseco_agasc_1p7.h5
+ Run on Fri Jun  3 12:54:10 EDT 2022 by jeanconn from owen-v.cfa.harvard.edu
+ Configuration:  Using AGASC at /proj/sot/ska3/test/data/agasc/proseco_agasc_1p7.h5
  chandra_models version: 3.40
 
 Short Term Schedule: JUN0622A
 
 ------------  PROCESSING FILES  -----------------
 
-DATA = /proj/sot/ska3/flight/lib/python3.8/site-packages/starcheck/data
+DATA = /proj/sot/ska3/test/lib/python3.8/site-packages/starcheck/data
 Using DOT file /data/mpcrit1/mplogs/2022/JUN0622/oflsa//mps/mdJUN0622A.dot
 Using OR file /data/mpcrit1/mplogs/2022/JUN0622/oflsa//mps/or/JUN0622_A.or
 Using TLR file /data/mpcrit1/mplogs/2022/JUN0622/oflsa//CR157_0903.tlr
 Using acq_star_rdb file ${DATA}/bad_acq_stars.rdb
-Using agasc_file file /proj/sot/ska3/flight/data/agasc/proseco_agasc_1p7.h5
+Using agasc_file file /proj/sot/ska3/test/data/agasc/proseco_agasc_1p7.h5
 Using aimpoint file /data/mpcrit1/mplogs/2022/JUN0622/oflsa//output/JUN0622A_dynamical_offsets.txt
 Using attitude file /data/mpcrit1/mplogs/2022/JUN0622/oflsa//History/ATTITUDE.txt
 Using backstop file /data/mpcrit1/mplogs/2022/JUN0622/oflsa//CR157_0903.backstop

task_schedule
The task_schedule internal tests were run on RHEL8 and showed expected results, so our processing/cron jobs can be run on RHEL8 systems as those systems become available.

Review

All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.

Deployment

ska3-flight 2022.6 will be promoted to flight conda channel and installed on HEAD and GRETA Linux upon approval of FSDS Jira ticket and at a time outside of the load review cycle.

Code changes

ska3-flight changes (2022.4 -> 2022.6rc3)

New Packages

aimpoint_mon: 1.0.1
fot-matlab: 2.0.0

Updated Packages

acis_thermal_check: 4.2.0 -> 4.3.1 (4.2.0 -> 4.3.0 -> 4.3.1)
- PR 50 (jzuhone): Check and plot the ACIS FP safety planning limit, support the new ACIS FP model
- PR 51 (jzuhone): Update test answers post-xija 4.26.1
agasc: 4.11.7 -> 4.12.0 (4.11.7 -> 4.12.0)
- PR 132 (javierggt): Do not count non-npm times when calculating f_ok
chandra_aca: 4.34.3 -> 4.35.0 (4.34.3 -> 4.35.0)
- PR 124 (taldcroft): Allow for broadcastable array inputs in snr_mag_for_t_ccd and guide_count
jobwatch: 0.7.0 -> 0.8.0 (0.7.0 -> 0.8.0)
- PR 55 (jeanconn): Use new solar wind png instead of old gif
kadi: 5.10.0 -> 5.11.0 (5.10.0 -> 5.11.0)
- PR 232 (taldcroft): Allow OCCweb access using noodle path
- PR 233 (taldcroft): Fix lucky testing and occweb lucky functionality
mica: 4.28.0 -> 4.29.0 (4.28.0 -> 4.29.0)
- PR 270 (jeanconn): Update ocat target table first in cron task
- PR 271 (jeanconn): Use CxoTime and fix time range for update
- PR 269 (javierggt): Remove use of Ska.Shell
- PR 272 (taldcroft): Improve speed of getting local OCAT data
parse_cm: 3.9.0 -> 3.9.1 (3.9.0 -> 3.9.1)
- PR 38 (taldcroft): Fix flake8 issues
proseco: 5.5.0 -> 5.6.0 (5.5.0 -> 5.6.0)
- PR 372 (taldcroft): Allow bonus faint guide stars for dyn bgd enabled
ska.arc5gl: 3.2.0 -> 3.3.0 (3.2.0 -> 3.3.0)
- PR 13 (jeanconn): Use arc5gl in ska3
ska.engarchive: 4.55.1 -> 4.55.3 (4.55.1 -> 4.55.2 -> 4.55.3)
- PR 230 (taldcroft): Fix test failure from updated MUPS model
- PR 231 (taldcroft): Try fixing the sporadic derived params aliases failure
ska.shell: 3.5.0 -> 3.5.1 (3.5.0 -> 3.5.1)
- PR 26 (javierggt): Fix for RedHat 8 (env vars that are functions)
ska.tdb: 3.6.0 -> 3.6.1 (3.6.0 -> -> 3.6.1)
- PR 17 (javierggt): convert docs to numpydoc
ska3-core: 2022.3 -> 2022.6rc3
ska3-template: 2019.09.03 -> 2022.06.02
- The updates in the template include changes to the production environment:
  - remove SKA/lib from LD_LIBRARY_PATH (no longer needed by our applications and removing it removes runtime library conflicts with OTS applications)
  - Update default ASCDS release used by Perl code to be the current ASCDS release (overrides logic to default to older DS releases on certain older systems)
  - Move to use of arc5gl with modern perl in ska3 instead of the old ska2 5.8.9 Perl.
sparkles: 4.16.0 -> 4.18.0 (4.16.0 -> 4.17.0 -> 4.18.0)
- PR 171 (taldcroft): Allow opening a pickle from Noodle/OCCweb
- PR 172 (taldcroft): Apply dyn bgd bonus in computing guide_count
- PR 170 (jeanconn): Move yoshi into sparkles and add some OCAT convenience
- PR 173 (taldcroft): Tweaks to sparkles / yoshi based on cycle 24 work
testr: 4.9.0 -> 4.11.0 (4.9.0 -> 4.10.0 -> 4.11.0)
- PR 43 (taldcroft): Add Coverage
- PR 44 (jeanconn): Add 185 subnet (owen-v) for on_head_network
xija: 4.26.0 -> 4.26.1 (4.26.0 -> 4.26.1)
- PR 121 (jkrist): Updated 'Hack' to only overwrite final prediction mvals instead of all mvals + PEP8

ska3-core changes (2022.3 -> 2022.6rc3)

New Packages

dataclasses: 0.8

Updated Packages

black: 19.10b0 -> 22.3.0
pathspec: 0.7.0 -> 0.9.0

Related Issues

Fixes #839
Fixes #858
Fixes #859
Fixes #861
Fixes #862
Fixes #863
Fixes #865
Fixes #866
Fixes #867
Fixes #868
Fixes #869
Fixes #870
Fixes #871

…chive, jobwatch

taldcroft · 2022-06-02T10:35:16Z

I installed this on my Mac and all ska_testr tests PASS. 🎉

pkg_defs/ska3-flight/meta.yaml

javierggt added 4 commits June 1, 2022 14:37

sync ska3-flight with ska3-matlab

e07c351

bump acis_thermal_check and parse_cm versions

8611aa6

update black version in ska3-core

a21fcda

add aimpoint_mon bump versions of ska3-template, ska.shell, ska.engar…

b069cdb

…chive, jobwatch

javierggt force-pushed the 2022.6 branch from 2e56835 to b069cdb Compare June 1, 2022 18:52

javierggt added 2 commits June 1, 2022 14:56

bump version of ska.arc5gl

f1f7295

bump version of sparkles

30a3e2c

jeanconn reviewed Jun 2, 2022

View reviewed changes

pkg_defs/ska3-flight/meta.yaml Outdated Show resolved Hide resolved

bump testr and Ska.tdb versions

535c588

javierggt force-pushed the 2022.6 branch from d05cc2b to 535c588 Compare June 2, 2022 15:05

jeanconn approved these changes Jun 3, 2022

View reviewed changes

javierggt merged commit 4e63ba5 into master Jun 10, 2022

javierggt deleted the 2022.6 branch August 3, 2022 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2022.6 #860

2022.6 #860

javierggt commented May 31, 2022 •

edited

Loading

taldcroft commented Jun 2, 2022

2022.6 #860

2022.6 #860

Conversation

javierggt commented May 31, 2022 • edited Loading

ska3-flight 2022.6

Interface Impacts:

Testing:

Test results

Review

Deployment

Code changes

ska3-flight changes (2022.4 -> 2022.6rc3)

New Packages

Updated Packages

ska3-core changes (2022.3 -> 2022.6rc3)

New Packages

Updated Packages

Related Issues

taldcroft commented Jun 2, 2022

javierggt commented May 31, 2022 •

edited

Loading