Allow for broadcastable array inputs in snr_mag_for_t_ccd and guide_count #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2022
javierggt
approved these changes
May 17, 2022
|
@javierggt - this PR itself does not depend on the other PR's. Should there be a lien on the others? |
|
ah, I guess not. |
This was referenced May 17, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the inputs to
snr_mag_for_t_ccdandguide_counta bit more general in allowing array inputs that are broadcast with each other.While in the code I tidied the doc strings a bit.
Interface impacts
The API is more general now but fully back-compatible.
Testing
Unit tests
Independent check of unit tests by Javier
Functional tests
Using this branch, both
prosecoandsparklesalso pass their unit tests, so there are no regressions introduced by the change in this PR.