Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OCCweb access using noodle path #232

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Allow OCCweb access using noodle path #232

merged 1 commit into from
Apr 29, 2022

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Apr 28, 2022

Description

Another little convenience PR related to noodle, going along with sot/sparkles#171. This allows the path for get_occweb_dir or get_occweb_page to start with one of the following Noodle paths:

  • \noodle\FOT
  • \noodle\GRETA\mission\Backstop
  • \noodle\vweb

Interface impacts

None.

Testing

Unit tests

  • Mac (new unit test)

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

This PR was used in the functional testing for sot/sparkles#171.

@taldcroft taldcroft requested a review from johnny1up April 28, 2022 22:08
@johnny1up
Copy link

This update looks good to me. I've spoken with Joe and plan to have more of Noodle mounted so we can continue to convert noodle to occweb links, so you may have a bit more mapping to do in the future. But for now, this looks good.

Copy link

@johnny1up johnny1up left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All updates look good. I actually took the time to review all the code in here and am impressed and appreciate this. Good to go.

@taldcroft
Copy link
Member Author

Thanks @johnny1up !

@taldcroft taldcroft merged commit e06ed0d into master Apr 29, 2022
@taldcroft taldcroft deleted the noodles-noodles branch April 29, 2022 15:18
@javierggt javierggt mentioned this pull request May 31, 2022
@javierggt javierggt mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants