Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arc5gl in ska3 #13

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Use arc5gl in ska3 #13

merged 1 commit into from
Jun 1, 2022

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented May 23, 2022

Description

Update to use arc5gl from SKA/bin instead of hardwired to /proj/sot/ska/bin/arc5gl (older ska env).

Fixes #3

Interface impacts

The module will now call the arc5gl in the path. It will fail if there is no arc5gl in the path.

Testing

Should be tested with skare3 with sot/skare3#855 .

Unit tests

  • No unit tests

Functional tests

I installed this in /proj/sot/ska3/test-rh8 and it worked to fetch some obspar files on RH8 and CentOS7.

Last login: Tue May 31 14:19:05 2022 from fido.cfa.harvard.edu
jeanconn-owen-v> source /proj/sot/ska3/test-rh8/bin/ska_envs.sh
jeanconn-owen-v> cd
jeanconn-owen-v> rm axaff*
jeanconn-owen-v> source /proj/sot/ska3/test-rh8/bin/ska_envs.sh
jeanconn-owen-v> conda list ska.arc5gl
# packages in environment at /proj/sot/ska3/test-rh8:
#
# Name                    Version                   Build  Channel
ska.arc5gl                3.2.1.dev5+g49d217b            py_0    file:///proj/sot/ska/jeanproj/git/skare3/builds
jeanconn-owen-v> ipython
Python 3.8.3 (default, May 19 2020, 18:47:26) 
Type 'copyright', 'credits' or 'license' for more information
IPython 7.29.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import Ska.arc5gl

In [2]: Ska.arc5gl.__file__
Out[2]: '/proj/sot/ska3/test-rh8/lib/python3.8/site-packages/Ska/arc5gl.py'

In [3]: arc5 = Ska.arc5gl.Arc5gl()

In [4]: arc5.sendline("obsid=703")

In [5]: arc5.sendline("get obspar")

In [6]:                                                                         
Do you really want to exit ([y]/n)? y
jeanconn-owen-v> ls axaff00703_000N005_obs0a.par.gz -l
-rw-rw----. 1 jeanconn jeanconn 1968 Jun  1 10:39 axaff00703_000N005_obs0a.par.gz

Also tested on CentOS7

In [1]: import Ska.arc5gl

In [2]: Ska.arc5gl.__file__
Out[2]: '/proj/sot/ska3/test-rh8/lib/python3.8/site-packages/Ska/arc5gl.py'

In [3]: arc5 = Ska.arc5gl.Arc5gl()
arc5.sen
In [4]: arc5.sendline("obsid=24448")

In [5]: arc5.sendline("get obspar")

In [6]:                                                                                                                                  
Do you really want to exit ([y]/n)? y
ls axjeanconn-fido> ls -l axaf*
-rw-rw---- 1 jeanconn jeanconn 1993 Jun  1 10:37 axaff24448_000N001_obs0a.par.gz

@jeanconn jeanconn changed the title WIP: Use arc5gl in ska3 Use arc5gl in ska3 May 31, 2022
@jeanconn jeanconn requested review from taldcroft and javierggt May 31, 2022 18:57
@jeanconn
Copy link
Contributor Author

I'd like to just add a unit test for the package in general but my preference would be to merge this PR and do that separately.

@jeanconn jeanconn merged commit 1e1d8d2 into master Jun 1, 2022
@jeanconn jeanconn deleted the arc5gl-path branch June 1, 2022 18:45
@javierggt javierggt mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use arc5gl script from within environment, not hardwired to /proj/sot/ska
2 participants