Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new solar wind png instead of old gif #55

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented May 3, 2022

Description

Update jobwatch to pay attention to the new file name for the solar wind data.

Interface impacts

No impact.

Testing

Unit tests

  • Linux

Functional tests

For functional tests, I confirmed the solar wind warning goes away with the new code using the new timestamp on the new file.

@jeanconn jeanconn changed the title WIP: Use new solar wind png instead of old gif Use new solar wind png instead of old gif May 31, 2022
@jeanconn jeanconn requested review from javierggt and taldcroft May 31, 2022 14:55
@javierggt
Copy link
Contributor

javierggt commented May 31, 2022

The change seems trivial, so I have nothing to say, as long as you tested it and that is the correct filename.

I did go check that the png file has a more recent timestamp though.

@jeanconn
Copy link
Contributor Author

I don't remember if I functionally tested. I'll go check to see if I remember how to do that.

@jeanconn
Copy link
Contributor Author

I did the functional testing. I also thought this was too trivial to bother but just went back and did that anyway. Not sure if I'm allowed to delete the unit tests done by another reviewer though. Still seems too trivial for that. @taldcroft ?

@jeanconn
Copy link
Contributor Author

jeanconn commented Jun 1, 2022

I'm going to chuck the requirement for independent reviewer run of the unit tests in this case.

@jeanconn jeanconn merged commit 3d71cf7 into master Jun 1, 2022
@jeanconn jeanconn deleted the solar_wind_png branch June 1, 2022 14:49
@javierggt javierggt mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants