Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test262 #892

Merged
merged 3 commits into from
Dec 9, 2019
Merged

update test262 #892

merged 3 commits into from
Dec 9, 2019

Conversation

mysticatea
Copy link
Contributor

This PR updates test262 to the latest and fix acorn for failed tests. (I wanted to use the updated test262 in #890 and #891.)

Failed tests are two groups:

  1. Add tests for BigInt disallowed in LegacyOctalLike and NonOctal literals tc39/test262#2253 ... BigInt literals disallow NonOctalDecimalIntegerLiteral (e.g. 08n).
  2. Add tests for valid identifier names also listed as reserved words  tc39/test262#2295 ... IdentifierName allows escaped keywords.

This PR moves the check of escaped keywords from creating tokens to consuming tokens. And this PR adds a parameter ignoreEscapeSequenceInKeyword to next() method and parseIdent() method uses it to ignore the error of escaped keywords.

This PR fixes #861 and fixes #881.

@marijnh marijnh merged commit 9675cfa into acornjs:master Dec 9, 2019
@marijnh
Copy link
Member

marijnh commented Dec 9, 2019

Wonderful. Merged!

@mysticatea mysticatea deleted the update-test262 branch December 9, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mysticatea @marijnh