Add tests for BigInt disallowed in LegacyOctalLike and NonOctal literals #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
reviewed
Jul 22, 2019
|
|
||
| $DONOTEVALUATE(); | ||
|
|
||
| 08n; |
There was a problem hiding this comment.
Given the filename, this should perhaps be 09n?
caiolima
reviewed
Jul 22, 2019
| @@ -0,0 +1,28 @@ | |||
| // Copyright (C) 2017 Robin Templeton. All rights reserved. | |||
There was a problem hiding this comment.
I copy and paste the files structure usually from the same folder. I changed this file but somehow forgot to save it. Thanks!
rkirsling
approved these changes
Jul 23, 2019
bakkot
approved these changes
Jul 23, 2019
|
Thanks @rkirsling, @bakkot, @devsnek, and @caiolima for the reviews! |
|
I merged it too early. The non octal parts need consensus from TC39. I'll hold on reverting as the meeting starts tomorrow, let's see what should be done to fix this here. |
|
For posterity: the change to the proposal got consensus, so these tests need not be reverted. |
mysticatea
added a commit
to mysticatea/acorn
that referenced
this pull request
Dec 8, 2019
marijnh
pushed a commit
to acornjs/acorn
that referenced
this pull request
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref tc39/proposal-bigint#208
cc @rkirsling