Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url-helper.ts now leverages well-known environment variables. #1941

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Conversation

jww3
Copy link
Contributor

@jww3 jww3 commented Oct 11, 2024

url-helper.ts had unnecessary complexity which could cause it to incorrectly infer common URLs.

This fix leverages well-known environment variables for the purposes of determining common URLs.

src/github-api-helper.ts Outdated Show resolved Hide resolved
src/ref-helper.ts Outdated Show resolved Hide resolved
src/url-helper.ts Outdated Show resolved Hide resolved
__test__/url-helper.test.ts Outdated Show resolved Hide resolved
src/url-helper.ts Show resolved Hide resolved
__test__/url-helper.test.ts Outdated Show resolved Hide resolved
__test__/url-helper.test.ts Outdated Show resolved Hide resolved
__test__/url-helper.test.ts Outdated Show resolved Hide resolved
jww3 and others added 2 commits October 17, 2024 13:49
Co-authored-by: Erez Testiler <easyt@github.com>
@jww3 jww3 marked this pull request as ready for review October 17, 2024 12:05
@jww3 jww3 requested a review from a team as a code owner October 17, 2024 12:05
src/url-helper.ts Outdated Show resolved Hide resolved
joshmgross
joshmgross previously approved these changes Oct 17, 2024
Copy link
Member

@joshmgross joshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are not blocking, but please take a look 😄

src/url-helper.ts Outdated Show resolved Hide resolved
src/url-helper.ts Outdated Show resolved Hide resolved
@jww3 jww3 merged commit 163217d into main Oct 18, 2024
12 checks passed
@jww3 jww3 deleted the api-url-fix branch October 18, 2024 08:07
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 24, 2024
| datasource  | package          | from   | to     |
| ----------- | ---------------- | ------ | ------ |
| github-tags | actions/checkout | v4.1.7 | v4.2.2 |


## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422)

-   `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941
-   Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946


## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421)

-   Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924


## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420)

-   Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180
-   Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 16, 2024
| datasource  | package          | from   | to     |
| ----------- | ---------------- | ------ | ------ |
| github-tags | actions/checkout | v4.1.7 | v4.2.2 |


## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422)

-   `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941
-   Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946


## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421)

-   Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924


## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420)

-   Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180
-   Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 16, 2024
| datasource  | package          | from   | to     |
| ----------- | ---------------- | ------ | ------ |
| github-tags | actions/checkout | v4.1.7 | v4.2.2 |


## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422)

-   `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941
-   Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946


## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421)

-   Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924


## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420)

-   Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180
-   Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 16, 2024
| datasource  | package          | from   | to     |
| ----------- | ---------------- | ------ | ------ |
| github-tags | actions/checkout | v4.1.7 | v4.2.2 |


## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422)

-   `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941
-   Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946


## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421)

-   Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924


## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420)

-   Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180
-   Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants