Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand unit test coverage for isGhes #1946

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Expand unit test coverage for isGhes #1946

merged 1 commit into from
Oct 23, 2024

Conversation

jww3
Copy link
Contributor

@jww3 jww3 commented Oct 18, 2024

isGhes is an exported function that was lacking unit test coverage. This PR adds unit tests for isGhes.

@jww3 jww3 changed the title Expand unit test coverage Expand unit test coverage for isGhes Oct 23, 2024
@jww3 jww3 marked this pull request as ready for review October 23, 2024 13:43
@jww3 jww3 requested a review from a team as a code owner October 23, 2024 13:43
@jww3 jww3 merged commit e3d2460 into main Oct 23, 2024
12 checks passed
@jww3 jww3 deleted the expand-isghes-unit-tests branch October 23, 2024 13:59
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 24, 2024
| datasource  | package          | from   | to     |
| ----------- | ---------------- | ------ | ------ |
| github-tags | actions/checkout | v4.1.7 | v4.2.2 |


## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422)

-   `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941
-   Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946


## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421)

-   Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924


## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420)

-   Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180
-   Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 16, 2024
| datasource  | package          | from   | to     |
| ----------- | ---------------- | ------ | ------ |
| github-tags | actions/checkout | v4.1.7 | v4.2.2 |


## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422)

-   `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941
-   Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946


## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421)

-   Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924


## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420)

-   Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180
-   Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 16, 2024
| datasource  | package          | from   | to     |
| ----------- | ---------------- | ------ | ------ |
| github-tags | actions/checkout | v4.1.7 | v4.2.2 |


## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422)

-   `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941
-   Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946


## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421)

-   Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924


## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420)

-   Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180
-   Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Dec 16, 2024
| datasource  | package          | from   | to     |
| ----------- | ---------------- | ------ | ------ |
| github-tags | actions/checkout | v4.1.7 | v4.2.2 |


## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422)

-   `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941
-   Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946


## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421)

-   Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924


## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420)

-   Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180
-   Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants