-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid URL for OpenSSF Scorecard Package #718
Comments
@jhutchings1 as this is your code, you may be the best person to address this issue And looking at the table and the logs, I suspect the bad URL may also be causing failure to get the "Score" and "Details" column data (all show "Unknown"). Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
|
👋 @dupuy Thanks for reporting this. I did have a couple of bugs here around the way I was building the query URL. The It'll be fixed by #725 |
@jhutchings1 thank you for the fix, it's been released in 4.2.4. |
In the latest update to this action, the OpenSSF Scorecard table generated by the dependency review action for the dependabot PR in my project's repo to update the version of that action, I get incorrect labels with invalid URLs:
actions/actions/dependency-review-action
As you can see,
actions/
is repeated in the anchor text. I'm not sure how or where in the code this is happening.I suspect the invalid URL is due to a faulty URL in the data (so, not necessarily a bug in the code), but I'm not sure where in the data this mistake (missing
:
afterhttps
in URL) was made.However, the code in
src/scorecard.ts
is already messing with the URL:The logic here could be enhanced to handle this not-uncommon error (as well as the possibility of an insecure
http:
prefix). This might best be done by using a regex likehttps?:?//
for the check and replace.The text was updated successfully, but these errors were encountered: