-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes to #718 #725
Bug fixes to #718 #725
Conversation
const parts = packageName.split('/') | ||
repositoryUrl = `github.com/${parts[0]}/${parts[1]}` // e.g. github.com/actions/checkout | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 nit: would be good to explicitly check this output in the new test case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the repositoryUrl isn't exposed outside of the function. Thoughts on how to bootstrap that into the tests? Was trying to avoid side effects on the Change object by using a local variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry late getting back to this. May the easiest play is to factor out 21-26 into a function that accepts a Change
and outputs a repositoryUrl
(or not) that line 29 can check, then test that in isolation with some Actions-flavored Change
s?
Again not the end of the world, since it's already landed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! One callout but happy to restamp after an update if you agree
Fixes #718
This pull request addresses the handling of GitHub Actions in the
scorecard.ts
andscorecard.test.ts
files. The changes include the addition of a special case for GitHub Actions in thegetScorecardLevels
function, modification of theapiRoot
URL, and the addition of new tests to verify these changes.