support for new go 1.20 #326

jason-huang-deltatre · 2023-02-03T03:28:55Z

Description:
CI failed after I specified the version to go 1.20, here is the error:

Error: perfutils/ballast/ballast.go:6:2: cannot find package "k8s.io/apimachinery/pkg/api/resource" in any of:
/opt/hostedtoolcache/go/1.2.2/x64/src/pkg/k8s.io/apimachinery/pkg/api/resource (from $GOROOT)
($GOPATH not set)

I guess it is because setup-go action picked up go version 1.2 by mistake. It should be version 1.20 (since go use semantic versioning). Can you guys please fix that?

Action version:
Latest version

Platform:

Ubuntu
macOS
Windows

Runner type:

Hosted
Self-hosted

Tools version:

Repro steps:
A description with steps to reproduce the issue. If your have a public example or repo to share, please provide the link.

Expected behavior:
A description of what you expected to happen.

Actual behavior:
A description of what is actually happening.

jason-huang-deltatre · 2023-02-03T04:02:24Z

If i set go 1.20, setup-go will grab go 1.2.2 instead of go 1.20. Issue solved by using tag go 1.20.0

cpanato · 2023-02-03T07:03:37Z

if use 1.20.x works

but looks like it is an issue in the github action infrastructure and not in the setup-go action itself

panticmilos · 2023-02-03T09:55:24Z

hi @jason-huang-deltatre, thank you for the report, we will take a look at it :)

leonbergr · 2023-02-03T10:25:35Z

I faced similar issue while having go version without apostrophes in gha .yaml file.
ie. good: go-version: '1.20'
bad go-version: 1.20

This this 1.20 => 1.2 conversion can happened to any value in gha .yaml without apostrophes

dmitry-shibanov · 2023-02-03T11:07:59Z

Hello everyone. I think it is an expected behaviour. You need to specify version like this go-version: '1.20'. You can check this comment for more information: actions/setup-python#160 (comment).

Thank you for your reply @leonbergr.

For now I'm going to close the issue.

I recently came across a bug where specifying `go-version: '1.20'` used Go 1.2, not 1.20. It was not clear from the readme that to avoid this, the Go version should be written inside single quotes (as per this comment: actions/setup-go#326 (comment)) but the single quotes are missing from the example in this repository. This PR fixes this.

actions/setup-go#326 (comment)

See actions/setup-go#326

cedws · 2023-04-16T22:15:41Z

I got bitten by this too... goddamn YAML.

More here: actions/setup-go#326 (comment)

* [INTG-2805] Adding date to the log * [INTG-2805] Use time.DateOnly instead * [INTG-2805] Upgrade to go1.20 * [INTG-2805] Fix tests for 1.20 * [INTG-2805] actions/setup-go#326 (comment) * [INTG-2805] Typo * [INTG-2805] Typo * [INTG-2805] Typo --------- Co-authored-by: Charles Lee <charles@Charles-Lees-MacBook-Pro.local>

xlab · 2023-05-24T14:02:33Z

see actions/setup-go#326

actions/setup-go#326

see: actions/setup-go#326

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* bump golang to 1.20 Signed-off-by: zachaller <zachaller@users.noreply.github.com> * use .x because of actions/setup-go#326 Signed-off-by: zachaller <zachaller@users.noreply.github.com> * use .x because of actions/setup-go#326 Signed-off-by: zachaller <zachaller@users.noreply.github.com> * change test to avoid loopclosure: loop variable test captured by func literal from go vet Signed-off-by: zachaller <zachaller@users.noreply.github.com> * ignore new govet rules for tests to pass Signed-off-by: zachaller <zachaller@users.noreply.github.com> * change closures Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix test Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix test Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix go vet by removing concurency Signed-off-by: zachaller <zachaller@users.noreply.github.com> * one more Signed-off-by: zachaller <zachaller@users.noreply.github.com> * copy var instead of removing Parallel Signed-off-by: zachaller <zachaller@users.noreply.github.com> * copy var instead of removing Parallel Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: zachaller <zachaller@users.noreply.github.com>

Based on: actions/setup-go#326

github action fails to pick up 1.20 correctly ref actions/setup-go#326

* Upgrade Go from 1.19 to 1.20. * Update tools to latest. * Bump controller-runtime from 0.16.2 to 0.16.3. Set version to 1.20.x in action/setup-go because of #actions/setup-go/issues/326

jason-huang-deltatre added bug Something isn't working needs triage labels Feb 3, 2023

cpanato mentioned this issue Feb 3, 2023

Upgrade to go1.20 sigstore/cosign#2689

Merged

panticmilos removed the needs triage label Feb 3, 2023

dmitry-shibanov closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023

This was referenced Feb 6, 2023

go-version: 1.20 installs go 1.2.2 #328

Closed

Support go1.20 #330

Closed

Loddan mentioned this issue Feb 8, 2023

Go version 1.20 specified in config file causes linting against Go 1.2. golangci/golangci-lint-action#669

Closed

3 tasks

vaughany mentioned this issue Feb 8, 2023

doc: add quote aroung go version golangci/golangci-lint-action#670

Merged

dmitry-shibanov mentioned this issue Mar 9, 2023

Partial version numbers don't work correctly. #344

Closed

5 tasks

MalteHerrmann mentioned this issue Mar 15, 2023

fix (ci): fix used Go version in CI by passing version as a string evmos/evmos#1471

Merged

rzetelskik mentioned this issue Mar 31, 2023

Update Go to 1.20 scylladb/scylla-operator#1196

Merged

This was referenced Apr 1, 2023

0s are ignored at the end of version numbers #364

Closed

Support for go 1.20? #365

Closed

colmsnowplow added a commit to snowplow/snowbridge that referenced this issue Apr 5, 2023

Patch gh action to ensure go 1.20 is used rather than 1.2

5f2434d

actions/setup-go#326 (comment)

wongoo pushed a commit to vogo/informer that referenced this issue Apr 7, 2023

fix go_version config for github action,see actions/setup-go#326

0865996

mattfenwick mentioned this issue Apr 7, 2023

go 1.20 mattfenwick/collections#1

Merged

obourdon added a commit to squarescale/squarescale-cli that referenced this issue Apr 13, 2023

Upgrade Golang to 1.20

4b77c19

See actions/setup-go#326

shu-mutou mentioned this issue Apr 17, 2023

Bump k8s modules to 0.27.1 kubernetes/dashboard#7715

Merged

bobg added a commit to bobg/fab that referenced this issue Apr 17, 2023

https://github.com/actions/setup-go/issues/326#issuecomment-1415719692

9084e34

This was referenced Apr 18, 2023

Update Golang to v1.20 for main branch. vmware-tanzu/velero#6158

Merged

[main]Replace busybox with internal copy binary and fix CVEs. vmware-tanzu/velero-plugin-for-gcp#137

Merged

peano88 added a commit to peano88/fizzbuzz-rest that referenced this issue Apr 19, 2023

fix gh action following actions/setup-go#326

2a69233

jdrews added a commit to jdrews/logstation that referenced this issue May 1, 2023

fix problem with go-version being picked up as 1.2.2

a60d110

More here: actions/setup-go#326 (comment)

jsturtevant mentioned this issue May 1, 2023

Update to golang 1.20 kubernetes-sigs/windows-gmsa#106

Merged

hkf57 added a commit to SafetyCulture/safetyculture-exporter that referenced this issue May 18, 2023

[INTG-2805] actions/setup-go#326 (comment)

f8f4359

pawelposkrobko added a commit to PiwikPRO/actions that referenced this issue May 26, 2023

HOTFIX-1 use 1.20.x. for go-version instead of 1.20

789d1dc

see actions/setup-go#326

pawelposkrobko mentioned this issue May 26, 2023

HOTFIX-1 use 1.20.x. for go-version instead of 1.20 PiwikPRO/actions#43

Merged

rsvihladremio added a commit to rsvihladremio/dremio-diagnostic-collector that referenced this issue May 30, 2023

fix from actions/setup-go#326

48d6bf0

tamada added a commit to tamada/crssy that referenced this issue Jun 15, 2023

fix the errors of parsing invalid go version

78844f3

actions/setup-go#326

anikin-aa mentioned this issue Jun 15, 2023

Update Golang to 1.20 version wal-g/wal-g#1492

Merged

jspeed-meyers mentioned this issue Jun 28, 2023

Add testing in CI protobom/protobom#27

Merged

sjdiego added a commit to sjdiego/fishbot that referenced this issue Jul 5, 2023

fix: set go version as string

a3f621c

see: actions/setup-go#326

jpmcb mentioned this issue Jul 13, 2023

GitHub actions: fixes broken actions workflows and adds PR tests open-sauced/pizza#15

Merged

19 tasks

Gearheads mentioned this issue Jul 21, 2023

feat(actions): update the go-version field to use a string instead of a number fidelity/kconnect#530

Merged

zachaller added a commit to zachaller/argo-rollouts that referenced this issue Jul 27, 2023

use .x because of actions/setup-go#326

962951a

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

zachaller added a commit to zachaller/argo-rollouts that referenced this issue Jul 27, 2023

use .x because of actions/setup-go#326

41b35ff

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

zachaller mentioned this issue Jul 28, 2023

chore: quote golang version string to not use go 1.2.2 argoproj/argo-rollouts#2915

Merged

levaitamas added a commit to l7mp/stunner that referenced this issue Aug 2, 2023

chore(CI/CD): Fix go version

9d0dd71

Based on: actions/setup-go#326

levaitamas added a commit to l7mp/stunner-auth-service that referenced this issue Aug 2, 2023

chore(CI/CD): Fix go version

f9c935c

Based on: actions/setup-go#326

levaitamas added a commit to l7mp/stunner-gateway-operator that referenced this issue Aug 2, 2023

chore(CI/CD): Fix go version

87a18f9

Based on: actions/setup-go#326

flexwie added a commit to flexwie/ghs that referenced this issue Aug 25, 2023

fix(ci): changed go version number

4e94f3a

github action fails to pick up 1.20 correctly ref actions/setup-go#326

ortex mentioned this issue Sep 5, 2023

more e2e tests roc-streaming/roc-go#112

Merged

moh-osman3 mentioned this issue Oct 13, 2023

Apply ci.yaml to all targets in the Makefile, not only top-level module open-telemetry/otel-arrow#38

Merged

NouemanKHAL mentioned this issue Oct 23, 2023

Upgrade go to 1.20 DataDog/datadog-firehose-nozzle#102

Merged

empovit mentioned this issue Nov 14, 2023

Upgrade Go from 1.19 to 1.20 fdo-rs/fdo-operator#112

Merged

daniellacosse mentioned this issue Dec 11, 2023

chore: add outline-go-tun2socks, except android Jigsaw-Code/outline-apps#1744

Merged

tnevrlka mentioned this issue Mar 14, 2024

fix: double quote goversion in the release action konflux-ci/qe-tools#111

Merged

iamrajhans added a commit to iamrajhans/local-ip-mapper that referenced this issue Oct 24, 2024

fix actions/setup-go#326

948f9af

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support for new go 1.20 #326

support for new go 1.20 #326

jason-huang-deltatre commented Feb 3, 2023 •

edited

Loading

jason-huang-deltatre commented Feb 3, 2023

cpanato commented Feb 3, 2023 •

edited

Loading

panticmilos commented Feb 3, 2023

leonbergr commented Feb 3, 2023

dmitry-shibanov commented Feb 3, 2023

cedws commented Apr 16, 2023

xlab commented May 24, 2023

support for new go 1.20 #326

support for new go 1.20 #326

Comments

jason-huang-deltatre commented Feb 3, 2023 • edited Loading

jason-huang-deltatre commented Feb 3, 2023

cpanato commented Feb 3, 2023 • edited Loading

panticmilos commented Feb 3, 2023

leonbergr commented Feb 3, 2023

dmitry-shibanov commented Feb 3, 2023

cedws commented Apr 16, 2023

xlab commented May 24, 2023

jason-huang-deltatre commented Feb 3, 2023 •

edited

Loading

cpanato commented Feb 3, 2023 •

edited

Loading