-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pypyX.Y
for PyPy python-version
input
#346
Comments
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9) `pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9 relates to actions#346
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9) `pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9 relates to actions#346
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9) `pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9 relates to actions#346
pypyX.Y
for python-version
inputpypyX.Y
for python-version
input
pypyX.Y
for python-version
inputpypyX.Y
for PyPy python-version
input
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
Hello @mayeut |
Hello @mayeut |
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9) `pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9 relates to actions#346
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9) `pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9 relates to actions#346
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
@marko-zivic-93, PR are already created and linked in the description. I'm waiting for PyPy 7.3.9 rollout on GHA to get them out of draft. |
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9) `pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9 relates to actions#346
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
@marko-zivic-93, #347 is ready for review. |
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9) `pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9 relates to actions#346
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9) `pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9 relates to #346
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
@marko-zivic-93, #349 is now ready for review. |
Hello @mayeut |
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes #346
Description:
Use
pypyX.Y
rather thanpypy-X.Y
forpython-version
inputStill allow
pypy-X.Y
for backward compatibility, maybe deprecate its usage ?Justification:
This allows
python-version
to match an actual executable name (c.f. note 1) and allowsnox
(& probablytox
too) to directly usepython-version
to narrow environment to be tested in a matrix job.It matches actual PyPy archive names e.g. pypy3.9-v7.3.8-linux64.tar.bz2, pypy2.7-v7.3.8-linux64.tar.bz2, ...
It would also be more in sync with virtualenv python discovery which states:
The current way to get this result involves removing the
-
which is not something workflow expressions currently allows & thus involves some bash magic to happen:It would allow to rewrite the workflow as:
Note 1: Windows is missing those executables for 3.7 & 3.8 for now but they will be available in PyPy 7.3.9
Are you willing to submit a PR?
pypyX.Y
symlinks #347pypX.Y
naming scheme: UsepypyX.Y
for PyPypython-version
input #349The text was updated successfully, but these errors were encountered: