-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pypyX.Y
for PyPy python-version
input
#349
Conversation
pypyX.Y
for PyPy python-version
input
An example can be seen here: https://github.com/mayeut/packaging/runs/5434696104?check_suite_focus=true matrix:
os: [Ubuntu, Windows, macOS]
python_version:
- ["3.7", "3.8", "3.9", "3.10", "pypy-3.7", "pypy-3.8", "pypy-3.9"]
+ ["3.7", "3.8", "3.9", "3.10", "pypy3.7", "pypy3.8", "pypy3.9"]
steps:
- uses: actions/checkout@v1
- uses: mayeut/setup-python@install-pypyX.Y-symlinks
- uses: mayeut/setup-python@pypyX.Y
name: Install Python ${{ matrix.python_version }}
with:
python-version: ${{ matrix.python_version }}
- name: Run nox
- run: |
- INTERPRETER_SPEC=${{ matrix.python_version }}
- INTERPRETER_SPEC=${INTERPRETER_SPEC/-/} # remove '-' in "pypy-3.x" -> "pypy3.x" to match executable name
- pipx run nox --error-on-missing-interpreters -s tests-${INTERPRETER_SPEC}
- shell: bash
+ run: pipx run nox --error-on-missing-interpreters -s tests-${{ matrix.python_version }} |
a9cf09d
to
843ba5d
Compare
The 4 failing |
do you know when you'll be able to review this ? |
Hello @mayeut. Could you please also sync with the main branch ? |
d8c69b7
to
98b28db
Compare
This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools. fixes actions#346
thanks for the review @dmitry-shibanov, all your comments have been addressed. |
@mayeut, thank you for your contribution! |
Could a new release be tagged, to be able to use this syntax? |
Hi @EwoutH, a new version of the action will be released in the coming days. |
Awesome, looking forward to it! |
Description:
Use
pypyX.Y
for PyPypython-version
inputThis versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools.
pypy-X.Y
kept for backward compatibility.Full rationale provided in #346.
Related issue:
fixes #346
Check list: