Skip to content

feature(session): add deadpool-redis compatibility #730

feature(session): add deadpool-redis compatibility

feature(session): add deadpool-redis compatibility #730

Triggered via pull request August 6, 2024 11:21
Status Failure
Total duration 1m 37s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 1 warning
clippy: actix-session/src/storage/redis_rs.rs#L297
[clippy] reported by reviewdog 🐶 error[E0507]: cannot move out of `self.client` as enum variant `Single` which is behind a shared reference --> actix-session/src/storage/redis_rs.rs:296:15 | 296 | match self.client { | ^^^^^^^^^^^ 297 | RedisSessionConn::Single(conn) => { | ---- data moved here ... 303 | RedisSessionConn::Pool(pool) => { | ---- ...and here | = note: move occurs because these variables have types that don't implement the `Copy` trait help: consider borrowing here | 296 | match &self.client { | + Raw Output: actix-session/src/storage/redis_rs.rs:297:38:e:error[E0507]: cannot move out of `self.client` as enum variant `Single` which is behind a shared reference --> actix-session/src/storage/redis_rs.rs:296:15 | 296 | match self.client { | ^^^^^^^^^^^ 297 | RedisSessionConn::Single(conn) => { | ---- data moved here ... 303 | RedisSessionConn::Pool(pool) => { | ---- ...and here | = note: move occurs because these variables have types that don't implement the `Copy` trait help: consider borrowing here | 296 | match &self.client { | + __END__
clippy: actix-session/src/storage/redis_rs.rs#L298
[clippy] reported by reviewdog 🐶 error[E0596]: cannot borrow `conn` as mutable, as it is not declared as mutable --> actix-session/src/storage/redis_rs.rs:298:17 | 298 | conn.expire::<_, ()>(&cache_key, ttl.whole_seconds()) | ^^^^ cannot borrow as mutable | help: consider changing this to be mutable | 297 | RedisSessionConn::Single(mut conn) => { | +++ Raw Output: actix-session/src/storage/redis_rs.rs:298:17:e:error[E0596]: cannot borrow `conn` as mutable, as it is not declared as mutable --> actix-session/src/storage/redis_rs.rs:298:17 | 298 | conn.expire::<_, ()>(&cache_key, ttl.whole_seconds()) | ^^^^ cannot borrow as mutable | help: consider changing this to be mutable | 297 | RedisSessionConn::Single(mut conn) => { | +++ __END__
clippy: actix-session/src/storage/redis_rs.rs#L351
[clippy] reported by reviewdog 🐶 error[E0277]: the trait bound `storage::redis_rs::RedisSessionConn: redis::aio::ConnectionLike` is not satisfied --> actix-session/src/storage/redis_rs.rs:351:35 | 351 | match cmd.query_async(client).await { | ----------- ^^^^^^ the trait `redis::aio::ConnectionLike` is not implemented for `storage::redis_rs::RedisSessionConn` | | | required by a bound introduced by this call | = help: the following other types implement trait `redis::aio::ConnectionLike`: deadpool_redis::Connection redis::aio::Connection<C> redis::aio::ConnectionManager redis::aio::MultiplexedConnection note: required by a bound in `redis::Cmd::query_async` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/redis-0.26.1/src/cmd.rs:436:24 | 434 | pub async fn query_async<T: FromRedisValue>( | ----------- required by a bound in this associated function 435 | &self, 436 | con: &mut impl crate::aio::ConnectionLike, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Cmd::query_async` Raw Output: actix-session/src/storage/redis_rs.rs:351:35:e:error[E0277]: the trait bound `storage::redis_rs::RedisSessionConn: redis::aio::ConnectionLike` is not satisfied --> actix-session/src/storage/redis_rs.rs:351:35 | 351 | match cmd.query_async(client).await { | ----------- ^^^^^^ the trait `redis::aio::ConnectionLike` is not implemented for `storage::redis_rs::RedisSessionConn` | | | required by a bound introduced by this call | = help: the following other types implement trait `redis::aio::ConnectionLike`: deadpool_redis::Connection redis::aio::Connection<C> redis::aio::ConnectionManager redis::aio::MultiplexedConnection note: required by a bound in `redis::Cmd::query_async` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/redis-0.26.1/src/cmd.rs:436:24 | 434 | pub async fn query_async<T: FromRedisValue>( | ----------- required by a bound in this associated function 435 | &self, 436 | con: &mut impl crate::aio::ConnectionLike, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Cmd::query_async` __END__
clippy: actix-session/src/storage/redis_rs.rs#L351
[clippy] reported by reviewdog 🐶 error[E0277]: the trait bound `storage::redis_rs::RedisSessionConn: redis::aio::ConnectionLike` is not satisfied --> actix-session/src/storage/redis_rs.rs:351:19 | 351 | match cmd.query_async(client).await { | ^^^^^^^^^^^^^^^^^^^^^^^ the trait `redis::aio::ConnectionLike` is not implemented for `storage::redis_rs::RedisSessionConn` | = help: the following other types implement trait `redis::aio::ConnectionLike`: deadpool_redis::Connection redis::aio::Connection<C> redis::aio::ConnectionManager redis::aio::MultiplexedConnection note: required by a bound in `redis::Cmd::query_async` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/redis-0.26.1/src/cmd.rs:436:24 | 434 | pub async fn query_async<T: FromRedisValue>( | ----------- required by a bound in this associated function 435 | &self, 436 | con: &mut impl crate::aio::ConnectionLike, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Cmd::query_async` Raw Output: actix-session/src/storage/redis_rs.rs:351:19:e:error[E0277]: the trait bound `storage::redis_rs::RedisSessionConn: redis::aio::ConnectionLike` is not satisfied --> actix-session/src/storage/redis_rs.rs:351:19 | 351 | match cmd.query_async(client).await { | ^^^^^^^^^^^^^^^^^^^^^^^ the trait `redis::aio::ConnectionLike` is not implemented for `storage::redis_rs::RedisSessionConn` | = help: the following other types implement trait `redis::aio::ConnectionLike`: deadpool_redis::Connection redis::aio::Connection<C> redis::aio::ConnectionManager redis::aio::MultiplexedConnection note: required by a bound in `redis::Cmd::query_async` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/redis-0.26.1/src/cmd.rs:436:24 | 434 | pub async fn query_async<T: FromRedisValue>( | ----------- required by a bound in this associated function 435 | &self, 436 | con: &mut impl crate::aio::ConnectionLike, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Cmd::query_async` __END__
clippy: actix-session/src/storage/redis_rs.rs#L351
[clippy] reported by reviewdog 🐶 error[E0277]: the trait bound `storage::redis_rs::RedisSessionConn: redis::aio::ConnectionLike` is not satisfied --> actix-session/src/storage/redis_rs.rs:351:43 | 351 | match cmd.query_async(client).await { | ^^^^^ the trait `redis::aio::ConnectionLike` is not implemented for `storage::redis_rs::RedisSessionConn` | = help: the following other types implement trait `redis::aio::ConnectionLike`: deadpool_redis::Connection redis::aio::Connection<C> redis::aio::ConnectionManager redis::aio::MultiplexedConnection note: required by a bound in `redis::Cmd::query_async` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/redis-0.26.1/src/cmd.rs:436:24 | 434 | pub async fn query_async<T: FromRedisValue>( | ----------- required by a bound in this associated function 435 | &self, 436 | con: &mut impl crate::aio::ConnectionLike, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Cmd::query_async` Raw Output: actix-session/src/storage/redis_rs.rs:351:43:e:error[E0277]: the trait bound `storage::redis_rs::RedisSessionConn: redis::aio::ConnectionLike` is not satisfied --> actix-session/src/storage/redis_rs.rs:351:43 | 351 | match cmd.query_async(client).await { | ^^^^^ the trait `redis::aio::ConnectionLike` is not implemented for `storage::redis_rs::RedisSessionConn` | = help: the following other types implement trait `redis::aio::ConnectionLike`: deadpool_redis::Connection redis::aio::Connection<C> redis::aio::ConnectionManager redis::aio::MultiplexedConnection note: required by a bound in `redis::Cmd::query_async` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/redis-0.26.1/src/cmd.rs:436:24 | 434 | pub async fn query_async<T: FromRedisValue>( | ----------- required by a bound in this associated function 435 | &self, 436 | con: &mut impl crate::aio::ConnectionLike, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Cmd::query_async` __END__
public-api-diff
Process completed with exit code 1.
clippy
The following actions uses Node.js version which is deprecated and will be forced to run on node20: giraffate/clippy-action@v1.0.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/