Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tokio utils to 0.3 #138

Merged
merged 4 commits into from
Jul 19, 2020
Merged

Upgrade tokio utils to 0.3 #138

merged 4 commits into from
Jul 19, 2020

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented May 18, 2020

PR Type

Dependency Update

PR Checklist

Check your PR fulfills the following:

  • A changelog entry has been made for the appropriate packages.

Overview

Updates tokio-utils to 0.3 in crates that need it and propagates type parameter changes. Also removes actix-ioframe as discussed.

@JohnTitor
Copy link
Member

@robjtede Are you still interested in working on this? I'd like to include this to the next codec release :)

@robjtede
Copy link
Member Author

robjtede commented Jul 8, 2020

Forgot about this one. Feel free to pick up the branch; will probably get done quicker.

@robjtede
Copy link
Member Author

I'm not convinced that ioframe is needed anymore.

@JohnTitor
Copy link
Member

JohnTitor commented Jul 15, 2020

I'm not convinced that ioframe is needed anymore.

Yeah, it's hard work to update it. Given the usage of that crate and the number of crates that depend on it, we could stop supporting it here, I think.

@robjtede robjtede marked this pull request as ready for review July 19, 2020 14:31
@robjtede robjtede requested review from a team July 19, 2020 14:33
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, could you also mention in the changelog?

actix-utils/src/framed.rs Outdated Show resolved Hide resolved
actix-utils/src/framed.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #138 into master will decrease coverage by 1.14%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   61.59%   60.44%   -1.15%     
==========================================
  Files          80       75       -5     
  Lines        5028     4806     -222     
==========================================
- Hits         3097     2905     -192     
+ Misses       1931     1901      -30     
Impacted Files Coverage Δ
actix-codec/src/bcodec.rs 44.44% <ø> (-55.56%) ⬇️
actix-utils/src/framed.rs 0.00% <0.00%> (ø)
actix-codec/src/framed.rs 22.13% <62.50%> (-21.78%) ⬇️
actix-server/src/lib.rs 50.00% <0.00%> (-16.67%) ⬇️
actix-service/src/lib.rs 36.36% <0.00%> (-6.07%) ⬇️
actix-utils/src/mpsc.rs 76.00% <0.00%> (-2.67%) ⬇️
actix-rt/src/system.rs 57.89% <0.00%> (-2.64%) ⬇️
actix-service/src/and_then.rs 88.75% <0.00%> (-2.50%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61176f6...230db53. Read the comment docs.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohnTitor JohnTitor merged commit 334c985 into master Jul 19, 2020
@robjtede robjtede deleted the upgrade/tokio-utils branch July 19, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants