-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade tokio utils to 0.3 #138
Conversation
@robjtede Are you still interested in working on this? I'd like to include this to the next codec release :) |
Forgot about this one. Feel free to pick up the branch; will probably get done quicker. |
0caaf91
to
934a986
Compare
I'm not convinced that ioframe is needed anymore. |
Yeah, it's hard work to update it. Given the usage of that crate and the number of crates that depend on it, we could stop supporting it here, I think. |
cbb3c49
to
d97aa4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, could you also mention in the changelog?
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 61.59% 60.44% -1.15%
==========================================
Files 80 75 -5
Lines 5028 4806 -222
==========================================
- Hits 3097 2905 -192
+ Misses 1931 1901 -30
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
PR Type
Dependency Update
PR Checklist
Check your PR fulfills the following:
Overview
Updates tokio-utils to 0.3 in crates that need it and propagates type parameter changes. Also removes
actix-ioframe
as discussed.