-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solve framed integration with actix-http #179
Conversation
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
- Coverage 60.47% 60.35% -0.12%
==========================================
Files 73 73
Lines 4784 4788 +4
==========================================
- Hits 2893 2890 -3
- Misses 1891 1898 +7
Continue to review full report at Codecov.
|
Not entirely sure why the 1.39 build is failing. There does appear to be a 1.40 feature in the crate mentioned, they do claim MSRV of 1.39 but their CI is passing? |
Because their MSRV check doesn't work correctly, submitted a fix: tokio-rs/tracing/pull/934 |
Btw, almost changes look great to me, I'll take a more look later about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Left one nit.
PR Type
Bug Fix / Refactor
PR Checklist
Check your PR fulfills the following:
Overview
Pin::new_unchecked
withpin_project
. #110.Framed
while attempting integration withactix-http
.Breaking Changes
Quick note: will address checklist as we go but this should probably be considered in tandem with actix/actix-web#1634