also try extracting payload config as Data<T> #1610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Ergonomics Improvement
PR Checklist
Check your PR fulfills the following:
Overview
When setting payload config it seems to make sense to check Data too to allow for programmer error (for lack of better phrase) in using
App::data
instead ofApp::app_data
to set config, especially since a mis-configuration currently does not result in an error message (because default fallback config is used).Follow-up Work
Apply same change to
Json
andForm
extractors.