-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract more config types from Data<T> as well #1641
Conversation
029edda
to
500a038
Compare
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
+ Coverage 53.07% 53.17% +0.09%
==========================================
Files 122 126 +4
Lines 11803 11836 +33
==========================================
+ Hits 6265 6294 +29
- Misses 5538 5542 +4
Continue to review full report at Codecov.
|
a8f5d35
to
8ac48b2
Compare
@actix/contributors could use your help to get v3 over the last couple hurdles :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me and I like this approach than a single type of app state
a9d6b3a
to
bc2f9e0
Compare
bc2f9e0
to
e92c0dd
Compare
PR Type
Feature
PR Checklist
Check your PR fulfills the following:
Overview
Follow up to #1610. Extracts Form and Json config objects as T and then tries Data<T> as well.