fix!: helixCut is renamed to helixCutTolerance and moved to SeedFinde…

…rOptions (#2653)

Following up on PR #2472 I have:
- Changed the name `helixCut` to `helixCutTolerance`
- Moved `helixCutTolerance` to SeedFinderOptions
- Added it to Orthogonal config and SeedFinderFTFConfig

BREAKING CHANGE:

The option `helixCut` is renamed to `helixCutTolerance` and moved to `SeedFinderOptions`

Core/include/Acts/Seeding/SeedFinder.ipp

@@ -723,7 +723,7 @@ inline void SeedFinder<external_spacepoint_t, platform_t>::filterCandidates(
 
       // sqrt(S2)/B = 2 * helixradius
       // calculated radius must not be smaller than minimum radius
-      if (S2 < B2 * options.minHelixDiameter2 * m_config.helixCut) {
+      if (S2 < B2 * options.minHelixDiameter2) {
         continue;
       }
 

Core/include/Acts/Seeding/SeedFinderConfig.hpp

@@ -101,9 +101,9 @@ struct SeedFinderConfig {
   // xyz
   float toleranceParam = 1.1 * Acts::UnitConstants::mm;
 
-  // Parameter which can loosen the tolerance of the track seed to form to a
-  // helix, useful for (e.g.) misaligned seeding
-  float helixCut = 1.;
+  // Parameter which can loosen the tolerance of the track seed to form a
+  // helix. This is useful for e.g. misaligned seeding.
+  float helixCutTolerance = 1.;
 
   // Geometry Settings
   // Detector ROI
@@ -130,6 +130,7 @@ struct SeedFinderConfig {
   // default is 5%
   // TODO: necessary to make amount of material dependent on detector region?
   float radLengthPerSeed = 0.05;
+
   // alignment uncertainties, used for uncertainties in the
   // non-measurement-plane of the modules
   // which otherwise would be 0
@@ -279,7 +280,8 @@ struct SeedFinderOptions {
     // TODO: change using ACTS units
     options.pTPerHelixRadius = 1_T * 1e6 * options.bFieldInZ;
     options.minHelixDiameter2 =
-        std::pow(config.minPt * 2 / options.pTPerHelixRadius, 2);
+        std::pow(config.minPt * 2 / options.pTPerHelixRadius, 2) *
+        config.helixCutTolerance;
     options.pT2perRadius =
         std::pow(config.highland / options.pTPerHelixRadius, 2);
     options.sigmapT2perRadius =

Core/include/Acts/Seeding/SeedFinderFTFConfig.hpp

@@ -42,6 +42,10 @@ struct SeedFinderFTFConfig {
   /// for load space points
   unsigned int maxSeedsPerSpM = 5;
 
+  // Parameter which can loosen the tolerance of the track seed to form a
+  // helix. This is useful for e.g. misaligned seeding.
+  float helixCutTolerance = 1.;
+
   float m_phiSliceWidth{};
   float m_nMaxPhiSlice{};
   bool m_useClusterWidth = false;

Core/include/Acts/Seeding/SeedFinderOrthogonalConfig.hpp

@@ -101,6 +101,10 @@ struct SeedFinderOrthogonalConfig {
   // TODO: necessary to make amount of material dependent on detector region?
   float radLengthPerSeed = 0.05;
 
+  // Parameter which can loosen the tolerance of the track seed to form a
+  // helix. This is useful for e.g. misaligned seeding.
+  float helixCutTolerance = 1.;
+
   // derived values, set on SeedFinder construction
   float highland = 0;
   float maxScatteringAngle2 = 0;