fix!: helixCut is renamed to helixCutTolerance and moved to SeedFinderOptions

[LuisFelipeCoelho]

Following up on PR #2472 I have:

• Changed the name helixCut to helixCutTolerance
• Moved helixCutTolerance to SeedFinderOptions
• Added it to Orthogonal config and SeedFinderFTFConfig

BREAKING CHANGE:

The option helixCut is renamed to helixCutTolerance and moved to SeedFinderOptions

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ebb7d40) 49.73% compared to head (e46a6a8) 49.73%.

Files	Patch %	Lines
Core/include/Acts/Seeding/SeedFinder.ipp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2653   +/-   ##
=======================================
  Coverage   49.73%   49.73%           
=======================================
  Files         474      474           
  Lines       26872    26872           
  Branches    12364    12364           
=======================================
  Hits        13366    13366           
  Misses       4702     4702           
  Partials     8804     8804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for e46a6a8

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[paulgessinger]

I don't see the removed config parameter in the diff. Where was this before?
Also I suppose this is a breaking change?

EDIT: indeed the helixCut parameter is still there. Is this intentional?

Invalidated by push of d8b0be2

[LuisFelipeCoelho]

I don't see the removed config parameter in the diff. Where was this before? Also I suppose this is a breaking change?

EDIT: indeed the helixCut parameter is still there. Is this intentional?

Thank you @paulgessinger. I removed the parameter now.

Yes, I guess this is breaking change because of the rename.

[CarloVarni]

just to comment that in Athena we are currently not manually setting helixCut so this requires no change from the Athena side, despite being a breaking change