refactor: convert to bound state also on empty sensitive surfaces. (#…

…3855)

This allows to merge retrieval of source link ranges, measurement selection and track state creation into one unit.

This increases the computational effort slightly for empty, sensitive surfaces, since the computation of bound states is slightly more demanding than the computation of curvilinear states, but for complex events like HL-LHC events the regression was not measurable.



Co-authored-by: Paul Gessinger <1058585+paulgessinger@users.noreply.github.com>

Core/include/Acts/TrackFinding/CombinatorialKalmanFilter.hpp

@@ -746,7 +746,7 @@ class CombinatorialKalmanFilter {
       }
 
       // Transport the covariance to the surface
-      if (isHole || isMaterialOnly) {
+      if (isMaterialOnly) {
         stepper.transportCovarianceToCurvilinear(state.stepping);
       } else {
         stepper.transportCovarianceToBound(state.stepping, *surface);

Examples/Python/tests/root_file_hashes.txt

@@ -33,21 +33,21 @@ test_digitization_example_input[smeared]__particles.root: 669d0304eb8bcf244aa627
 test_digitization_example_input[smeared]__measurements.root: 243c2f69b7b0db9dbeaa7494d4ea0f3dd1691dc90f16e10df6c0491ff4dc7d62
 test_digitization_example_input[geometric]__particles.root: 669d0304eb8bcf244aa627809a117944e5e3b994fdfcfb8710f2b9a8f9a62d3b
 test_digitization_example_input[geometric]__measurements.root: 63ec81635979058fb8976f94455bf490cf92b7b142c4a05cc39de6225f5de2fb
-test_ckf_tracks_example[generic-full_seeding]__trackstates_ckf.root: ec6487dfca5f944cfacfef903eb4b9a97f8f6a668d07f77d0c3ec45c68054824
-test_ckf_tracks_example[generic-full_seeding]__tracksummary_ckf.root: 84085bcc63562cfb1b4c70d2665bf06938ac559bb40c2b01c076e1d8b5c7b43b
+test_ckf_tracks_example[generic-full_seeding]__trackstates_ckf.root: f0b4c6018d0b2641024b88f6ac717f16a2ca486007c2e9bf166c85dc5e161739
+test_ckf_tracks_example[generic-full_seeding]__tracksummary_ckf.root: e5187591a0902d7214dd211adf459e2ec43b200b43c7ebdb90e5af50ee828f91
 test_ckf_tracks_example[generic-full_seeding]__performance_seeding_trees.root: 0e0676ffafdb27112fbda50d1cf627859fa745760f98073261dcf6db3f2f991e
-test_ckf_tracks_example[generic-truth_estimated]__trackstates_ckf.root: 8e15cceeef4b115708596702988925b7506d39e0531dc5534636ec411a9b4ca2
-test_ckf_tracks_example[generic-truth_estimated]__tracksummary_ckf.root: 8e0116c656e1cc67446d54a5205c4a3e2f4c1fc90fa551bb608c881877dfa0ab
+test_ckf_tracks_example[generic-truth_estimated]__trackstates_ckf.root: 1d3198e1926cf2c568d1c854c3ec7d638ed296163ac3cd1ff68273ab21a12657
+test_ckf_tracks_example[generic-truth_estimated]__tracksummary_ckf.root: 0b0266b28e20efab834b74e816ed9c658527496f6ef55ca8c073133aae0825b1
 test_ckf_tracks_example[generic-truth_estimated]__performance_seeding.root: 1facb05c066221f6361b61f015cdf0918e94d9f3fce2269ec7b6a4dffeb2bc7e
-test_ckf_tracks_example[generic-truth_smeared]__trackstates_ckf.root: 82a6744980553e6274df78eea15f0dec22676b1c04e14afc3828bff9bbf5e1b1
-test_ckf_tracks_example[generic-truth_smeared]__tracksummary_ckf.root: 06d6ae1d05cb611b19df3c59531997c9b0108f5ef6027d76c4827bd2d9edb921
-test_ckf_tracks_example[odd-full_seeding]__trackstates_ckf.root: 53a96c225ed78bd7da1491ae3ff4173f0e6c8bffe27e3eab1ab7adfe55426080
+test_ckf_tracks_example[generic-truth_smeared]__trackstates_ckf.root: d043c7d28772954fa2c1e4b320384c26589586bc4cdd95e0506fab59a37135d7
+test_ckf_tracks_example[generic-truth_smeared]__tracksummary_ckf.root: f063e4ab1f7f55106fa8b61bac627ca4739f04434ee35c77db603910a6e1a747
+test_ckf_tracks_example[odd-full_seeding]__trackstates_ckf.root: d5388653cf5613e765e6ce1e5afe94d94ff5182d7734e75251bc415f0192f444
 test_ckf_tracks_example[odd-full_seeding]__tracksummary_ckf.root: 2a98d8ec8fae97e18f4661580b71885f558d7222f94bca5edfbf5cdb595021f7
 test_ckf_tracks_example[odd-full_seeding]__performance_seeding_trees.root: 43c58577aafe07645e5660c4f43904efadf91d8cda45c5c04c248bbe0f59814f
-test_ckf_tracks_example[odd-truth_estimated]__trackstates_ckf.root: 7ec5f4b24fa69bfc9d812a6f224d74d36df2d0a42aef791ae0116f309d6f1433
+test_ckf_tracks_example[odd-truth_estimated]__trackstates_ckf.root: 6ed8f0db3f3e7f1b71b6d9da7371597d4fb5f95b3d2f2ab18be43d1763ce41c1
 test_ckf_tracks_example[odd-truth_estimated]__tracksummary_ckf.root: 1eaae038ced2cc5c757480ca42eab60cdaff14d812c34a807a841267d6bfa110
 test_ckf_tracks_example[odd-truth_estimated]__performance_seeding.root: 1a36b7017e59f1c08602ef3c2cb0483c51df248f112e3780c66594110719c575
-test_ckf_tracks_example[odd-truth_smeared]__trackstates_ckf.root: 35a65e15a6f479f628a96f56ee78e1ac371d71a686ee0c974944d681499fe6bd
+test_ckf_tracks_example[odd-truth_smeared]__trackstates_ckf.root: a519202b1233d8e7aac3c9038ee6e16b5d3cdfe2027212d6900e00ee0fcec21d
 test_ckf_tracks_example[odd-truth_smeared]__tracksummary_ckf.root: 3e257de624674fa9a19dcc72598c78c29a52633821acaa56dc2aa39a1395f1b5
 test_vertex_fitting_reading[Truth-False-100]__performance_vertexing.root: 76ef6084d758dfdfc0151ddec2170e12d73394424e3dac4ffe46f0f339ec8293
 test_vertex_fitting_reading[Iterative-False-100]__performance_vertexing.root: 60372210c830a04f95ceb78c6c68a9b0de217746ff59e8e73053750c837b57eb