refactor: convert to bound state also on empty sensitive surfaces. #3855

goetzgaycken · 2024-11-12T18:04:36Z

This allows to merge retrieval of source link ranges, measurement selection and track state creation into one unit.

This increases the computational effort slightly for empty, sensitive surfaces, since the computation of bound states is slightly more demanding than the computation of curvilinear states, but for complex events like HL-LHC events the regression was not measurable.

--- END COMMIT MESSAGE ---

This changes track states on surfaces without measurements, which are in curvilinear parameterisation before this change but parameterised as bound states after this change. This also slightly changes some values of the track summary tree (O(10^6); err_{eLOC1,eTHETA,eQOP}_fit, pull_{eLOC1,eTHETA,eQOP}_fit)

Summary by CodeRabbit

New Features
- Enhanced track finding and filtering processes with improved logic in the CombinatorialKalmanFilter.
Bug Fixes
- Updated error handling in the filtering process to prevent unnecessary processing when no measurements are available.
Tests
- Updated hash values for multiple test files to reflect recent modifications in their contents.

coderabbitai · 2024-11-12T18:04:46Z

Walkthrough

Changes made to the CombinatorialKalmanFilter class in Core/include/Acts/TrackFinding/CombinatorialKalmanFilter.hpp focus on control flow, error handling, and method signatures. The logic for transporting covariance has been simplified, error handling in the filter method has been improved, and the branch stopper logic has been refined. Additionally, hash values for several test files in Examples/Python/tests/root_file_hashes.txt have been updated to reflect modifications in their contents.

Changes

File Path	Change Summary
Core/include/Acts/TrackFinding/CombinatorialKalmanFilter.hpp	- Simplified covariance transport condition. - Improved error handling in `filter` method. - Refined branch stopper logic. - Adjusted method signatures for clarity and efficiency.
Examples/Python/tests/root_file_hashes.txt	- Updated hash values for multiple test files indicating changes in their contents.

Poem

In the realm of code, changes unfold,
A Kalman filter, now brave and bold.
With logic refined, and hashes anew,
A path clearer, for all to pursue.
Oh, celebrate we must, this joyous spree,
For progress in code, brings harmony! ✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9f2e208 and 9ae0171.

📒 Files selected for processing (1)

Core/include/Acts/TrackFinding/CombinatorialKalmanFilter.hpp (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

Core/include/Acts/TrackFinding/CombinatorialKalmanFilter.hpp

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

goetzgaycken · 2024-11-12T18:04:56Z

maybe it is a feature rather than refactor ?

github-actions · 2024-11-12T19:03:55Z

📊: Physics performance monitoring for `9ae0171`

Full contents

physmon summary

paulgessinger · 2024-11-13T08:06:30Z

This changes hashes as expected.

paulgessinger · 2024-11-21T14:50:10Z

If @andiwand has no objections, can you update t he references @goetzgaycken?

andiwand · 2024-11-21T14:51:30Z

LGTM 👍

goetzgaycken · 2024-11-21T15:26:24Z

If @andiwand has no objections, can you update t he references @goetzgaycken?

did so. Thanks !

paulgessinger · 2024-11-22T07:59:35Z

@goetzgaycken Unfortunately, the hash file has conflicts with main now. Can you resolve them?

goetzgaycken · 2024-11-25T13:39:38Z

changes from a26c65b to 7718c45:

revert changes to hashes
rebase to main 7718c45

next step update to new hashes.

This allows to merge retrieval of source link ranges, measurement selection and track state creation into one unit. This increases the computational effort slightly for empty, sensitive surfaces, since the computation of bound states is slightly more demanding than the computation of curvilinear states, but for complex events like HL-LHC events the regression was not measurable. This changes track states on surfaces without measurements, because the parameterisation for such states changes from curvilinear to bound.

goetzgaycken · 2024-11-25T15:02:20Z

above changes 7718c45 to 7b8b1b8:

updated hashes.

…faces

sonarqubecloud · 2024-11-26T19:38:06Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

acts-project-service · 2024-11-26T21:46:17Z

✅ Athena integration test results [`4cd88af`]

✅ All tests successful

status	job	report
🟢	report_pull_request
🟢	run_art_test: test_run4_acts_vertex_PU200
🟢	run_art_test: test_run4_ttbar_PU200
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	test_ActsDumpGeometryIdentifiers
🟢	test_ActsCheckObjectCountsWorkflowHgtd
🟢	test_ActsCheckObjectCountsCachedWorkflow
🟢	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_unit_tests

github-actions bot added Component - Core Affects the Core module Track Finding labels Nov 12, 2024

paulgessinger added this to the next milestone Nov 21, 2024

goetzgaycken force-pushed the convert_to_bound_state_for_all_sensitive_surfaces branch from 0eb6c0d to e704247 Compare November 21, 2024 15:25

github-actions bot added Component - Examples Affects the Examples module Changes Performance labels Nov 21, 2024

goetzgaycken force-pushed the convert_to_bound_state_for_all_sensitive_surfaces branch from e704247 to a26c65b Compare November 21, 2024 17:51

goetzgaycken force-pushed the convert_to_bound_state_for_all_sensitive_surfaces branch from a26c65b to 7718c45 Compare November 25, 2024 13:37

github-actions bot removed Component - Examples Affects the Examples module Changes Performance labels Nov 25, 2024

goetzgaycken force-pushed the convert_to_bound_state_for_all_sensitive_surfaces branch from 7718c45 to 7b8b1b8 Compare November 25, 2024 14:59

github-actions bot added Component - Examples Affects the Examples module Changes Performance labels Nov 25, 2024

update hashes again

9f2e208

andiwand approved these changes Nov 26, 2024

View reviewed changes

andiwand added the automerge label Nov 26, 2024

Merge branch 'main' into convert_to_bound_state_for_all_sensitive_sur…

9ae0171

…faces

kodiakhq bot merged commit 4cd88af into acts-project:main Nov 26, 2024
45 checks passed

github-actions bot removed the automerge label Nov 26, 2024

acts-project-service added the Breaks Athena build This PR breaks the Athena build label Nov 26, 2024

This was referenced Nov 27, 2024

chore: replace some couts with logger #3912

Merged

feat: compatibility for EDM4hep < 0.99 & >= 0.99 #3921

Merged

paulgessinger modified the milestones: next, v38.0.0 Nov 29, 2024

coderabbitai bot mentioned this pull request Dec 19, 2024

fix: Output correct track objects in GSF refitting #3999

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: convert to bound state also on empty sensitive surfaces. #3855

refactor: convert to bound state also on empty sensitive surfaces. #3855

goetzgaycken commented Nov 12, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 12, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

goetzgaycken commented Nov 12, 2024

github-actions bot commented Nov 12, 2024 •

edited

Loading

paulgessinger commented Nov 13, 2024

paulgessinger commented Nov 21, 2024

andiwand commented Nov 21, 2024

goetzgaycken commented Nov 21, 2024

paulgessinger commented Nov 22, 2024

goetzgaycken commented Nov 25, 2024

goetzgaycken commented Nov 25, 2024

sonarqubecloud bot commented Nov 26, 2024

acts-project-service commented Nov 26, 2024 •

edited

Loading

refactor: convert to bound state also on empty sensitive surfaces. #3855

refactor: convert to bound state also on empty sensitive surfaces. #3855

Conversation

goetzgaycken commented Nov 12, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Nov 12, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

goetzgaycken commented Nov 12, 2024

github-actions bot commented Nov 12, 2024 • edited Loading

📊: Physics performance monitoring for 9ae0171

physmon summary

paulgessinger commented Nov 13, 2024

paulgessinger commented Nov 21, 2024

andiwand commented Nov 21, 2024

goetzgaycken commented Nov 21, 2024

paulgessinger commented Nov 22, 2024

goetzgaycken commented Nov 25, 2024

goetzgaycken commented Nov 25, 2024

sonarqubecloud bot commented Nov 26, 2024

Quality Gate passed

acts-project-service commented Nov 26, 2024 • edited Loading

✅ Athena integration test results [4cd88af]

✅ All tests successful

goetzgaycken commented Nov 12, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 12, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Nov 12, 2024 •

edited

Loading

📊: Physics performance monitoring for `9ae0171`

acts-project-service commented Nov 26, 2024 •

edited

Loading

✅ Athena integration test results [`4cd88af`]