Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove volumeSignature from geometry building #1731

Closed
paulgessinger opened this issue Dec 12, 2022 · 1 comment · Fixed by #2759 or #2767
Closed

Remove volumeSignature from geometry building #1731

paulgessinger opened this issue Dec 12, 2022 · 1 comment · Fixed by #2759 or #2767
Labels
Stale

Comments

@paulgessinger
Copy link
Member

I think this is a relic from the ATLAS software originally.
@stale
Copy link

stale bot commented Jan 16, 2023

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@stale stale bot added the Stale label Jan 16, 2023
@AJPfleger AJPfleger mentioned this issue Dec 1, 2023
Merged
@kodiakhq kodiakhq bot closed this as completed in #2759 Dec 5, 2023
kodiakhq bot pushed a commit that referenced this issue Dec 5, 2023
@AJPfleger
chore: Remove volumeSignature from geometry building (#2759)
34bd984 
Seems to have no purpose anymore in ACTS.

I was introduced in the pre-PR time: cd4c063

Closes #1731
@AJPfleger AJPfleger mentioned this issue Dec 5, 2023
Merged
asalzburger pushed a commit to asalzburger/acts that referenced this issue Dec 6, 2023
@AJPfleger @asalzburger
chore: Remove volumeSignature from geometry building (acts-project#…
7332eb4 
…2759)

Seems to have no purpose anymore in ACTS.

I was introduced in the pre-PR time: acts-project@cd4c063

Closes acts-project#1731
@paulgessinger paulgessinger reopened this Dec 6, 2023
@kodiakhq kodiakhq bot closed this as completed in #2767 Jan 16, 2024
kodiakhq bot pushed a commit that referenced this issue Jan 16, 2024
@AJPfleger
chore!: Remove volumeSignature from geometry building (#2767)
d8e46ff 
After reverting with #2764 because it broke Athena, here again for the next major release.

Closes #1731

BREAKING CHANGE: `volumeSignature` Seems to have no purpose anymore in ACTS.

It was introduced in the pre-PR time: cd4c063

API change: All layer-geometry based builders lose the `volumeSignature` config property.
LaraCalic pushed a commit to LaraCalic/acts that referenced this issue Feb 10, 2024
@AJPfleger @LaraCalic
chore!: Remove volumeSignature from geometry building (acts-project#2767
cf206c8 
)

After reverting with acts-project#2764 because it broke Athena, here again for the next major release.

Closes acts-project#1731

BREAKING CHANGE: `volumeSignature` Seems to have no purpose anymore in ACTS.

It was introduced in the pre-PR time: acts-project@cd4c063

API change: All layer-geometry based builders lose the `volumeSignature` config property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
1 participant
@paulgessinger