chore!: Remove volumeSignature from geometry building #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2767 +/- ##
=======================================
Coverage 48.90% 48.90%
=======================================
Files 491 491
Lines 28561 28561
Branches 13487 13487
=======================================
Hits 13967 13967
Misses 4861 4861
Partials 9733 9733 ☔ View full report in Codecov by Sentry. |
📊: Physics performance monitoring for 56b9473physmon summary
|
andiwand
approved these changes
Jan 16, 2024
acts-project-service
added
the
Breaks Athena build
paulgessinger
added
Breaks Athena build
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
) After reverting with acts-project#2764 because it broke Athena, here again for the next major release. Closes acts-project#1731 BREAKING CHANGE: `volumeSignature` Seems to have no purpose anymore in ACTS. It was introduced in the pre-PR time: acts-project@cd4c063 API change: All layer-geometry based builders lose the `volumeSignature` config property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reverting with #2764 because it broke Athena, here again for the next major release.
Closes #1731
BREAKING CHANGE:
volumeSignatureSeems to have no purpose anymore in ACTS.It was introduced in the pre-PR time: cd4c063
API change: All layer-geometry based builders lose the
volumeSignatureconfig property.