refactor!: Introduce regular surface intermediate class

[paulgessinger]

This adds a new class

class RegularSurface : public Surface {};

that reimplements a number of functions while discarding the direction argument.

[paulgessinger]

I extracted the changes to normal and the introduction of coerceToSurface to #2344, so we can evaluate whether this is a good idea separately.

[codecov]

Codecov Report

Merging #2340 (d2f6c21) into main (c3ceb12) will increase coverage by 0.09%.
The diff coverage is 69.64%.

@@            Coverage Diff             @@
##             main    #2340      +/-   ##
==========================================
+ Coverage   49.61%   49.71%   +0.09%     
==========================================
  Files         473      474       +1     
  Lines       26844    26859      +15     
  Branches    12362    12362              
==========================================
+ Hits        13319    13352      +33     
+ Misses       4753     4706      -47     
- Partials     8772     8801      +29     

Files	Coverage Δ
Core/include/Acts/Detector/Portal.hpp	100.00% <ø> (ø)
...e/include/Acts/Digitization/DigitizationModule.hpp	66.66% <ø> (ø)
Core/include/Acts/Digitization/Segmentation.hpp	100.00% <ø> (ø)
Core/include/Acts/Geometry/VolumeBounds.hpp	40.00% <ø> (ø)
Core/include/Acts/Surfaces/ConeSurface.hpp	100.00% <ø> (ø)
Core/include/Acts/Surfaces/CylinderSurface.hpp	100.00% <ø> (ø)
Core/include/Acts/Surfaces/DiscSurface.hpp	100.00% <ø> (ø)
Core/include/Acts/Surfaces/LineSurface.hpp	100.00% <ø> (ø)
Core/include/Acts/Surfaces/PerigeeSurface.hpp	100.00% <ø> (ø)
Core/include/Acts/Surfaces/PlaneSurface.hpp	100.00% <ø> (ø)
... and 15 more

... and 4 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[github-actions]

📊: Physics performance monitoring for d2f6c21

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[acts-project-service]

🔴 Athena integration test results [85a0fea]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🟢	run_unit_tests
🔴	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsBenchmarkWithSpot.sh 8 100
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateResolvedTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🔴	run_workflow_tests_run3_data

[paulgessinger]

This is rebased again. Should we just merge it @andiwand?

[paulgessinger]

Ok I might have to fix some compile issues and also the Athena build seems to be failing on this in an unexpected way.

[paulgessinger]

Ready again now I think @andiwand.