Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce concepts for (Regular)Surface #2646

Merged
merged 39 commits into from
Nov 21, 2023

Conversation

paulgessinger
Copy link
Member

This helps catching missing using methods to make derived classes fully comply with the base Surface class. C++ inheritance is strange.

Blocked by:

paulgessinger and others added 30 commits August 3, 2023 16:05
This is now only available in Plane and DiscSurface
@github-actions github-actions bot added Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation Event Data Model Vertexing Track Fitting labels Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d1dc45) 49.56% compared to head (dc26178) 49.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2646   +/-   ##
=======================================
  Coverage   49.56%   49.56%           
=======================================
  Files         474      474           
  Lines       26930    26930           
  Branches    12423    12423           
=======================================
  Hits        13348    13348           
  Misses       4748     4748           
  Partials     8834     8834           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger paulgessinger marked this pull request as ready for review November 12, 2023 20:04
@github-actions github-actions bot removed Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation Event Data Model Vertexing Track Fitting labels Nov 12, 2023
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Nov 15, 2023
@paulgessinger
Copy link
Member Author

Unblocked now!

@kodiakhq kodiakhq bot merged commit e574e8a into acts-project:main Nov 21, 2023
51 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Nov 21, 2023

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 21, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants