-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce concepts for (Regular)Surface #2646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now only available in Plane and DiscSurface
github-actions
bot
added
Component - Fatras
Affects the Fatras module
Component - Plugins
Affects one or more Plugins
Component - Documentation
Affects the documentation
Event Data Model
Vertexing
Track Fitting
labels
Nov 9, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2646 +/- ##
=======================================
Coverage 49.56% 49.56%
=======================================
Files 474 474
Lines 26930 26930
Branches 12423 12423
=======================================
Hits 13348 13348
Misses 4748 4748
Partials 8834 8834 ☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
Component - Fatras
Affects the Fatras module
Component - Plugins
Affects one or more Plugins
Component - Documentation
Affects the documentation
Event Data Model
Vertexing
Track Fitting
labels
Nov 12, 2023
Unblocked now! |
andiwand
approved these changes
Nov 15, 2023
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Fails Athena tests
This PR causes a failure in the Athena tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps catching missing
using
methods to make derived classes fully comply with the baseSurface
class. C++ inheritance is strange.Blocked by: