fix: Fix Fatras end of world #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2580 +/- ##
=======================================
Coverage 49.63% 49.63%
=======================================
Files 471 471
Lines 26687 26687
Branches 12277 12277
=======================================
Hits 13245 13245
Misses 4746 4746
Partials 8696 8696
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
previously approved these changes
Oct 25, 2023
yes exactly - the end of the world check and path limit should terminate the propagation if we are going too far and the step size limit should protect us from an unconstrained straight line step into infinity |
andiwand
commented
Oct 25, 2023
Examples/Algorithms/Fatras/include/ActsExamples/Fatras/FatrasSimulation.hpp
Outdated
Show resolved
Hide resolved
github-actions
bot
added
Infrastructure
paulgessinger
approved these changes
Oct 27, 2023
acts-project-service
added
the
Fails Athena tests
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 28, 2023
We are currently mixing where we set masks and some of them are not accurate anymore. Here I try to reduce the masks to a minimum and set them in the code when appropriate. blocked by: - #2580
paulgessinger
removed
the
Fails Athena tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the Fatras propagation will not terminate and step with
double maxdistance which results in FPEsAfter these changes the FPEs during propagation disappeared