Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor FPE masks in Examples #2581

Merged
merged 6 commits into from
Oct 28, 2023

Conversation

andiwand
Copy link
Contributor

We are currently mixing where we set masks and some of them are not accurate anymore. Here I try to reduce the masks to a minimum and set them in the code when appropriate.

blocked by:

@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Oct 25, 2023
@andiwand andiwand added this to the next milestone Oct 25, 2023
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Oct 25, 2023
@andiwand andiwand changed the title refactor: Refactor FPE masks refactor: Refactor FPE masks in Examples Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2581 (3fe62d0) into main (fa3e67e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2581   +/-   ##
=======================================
  Coverage   49.63%   49.63%           
=======================================
  Files         471      471           
  Lines       26690    26690           
  Branches    12278    12278           
=======================================
  Hits        13247    13247           
  Misses       4748     4748           
  Partials     8695     8695           
Files Coverage Δ
Core/include/Acts/TrackFitting/detail/GsfUtils.hpp 60.00% <100.00%> (ø)
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 41.29% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Oct 27, 2023
@kodiakhq kodiakhq bot merged commit 166c57a into acts-project:main Oct 28, 2023
55 checks passed
@andiwand andiwand deleted the refactor-fpe-masks branch October 28, 2023 09:16
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 28, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 6, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Track Fitting Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants