-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor FPE masks in Examples #2581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Infrastructure
Changes to build tools, continous integration, ...
label
Oct 25, 2023
andiwand
changed the title
refactor: Refactor FPE masks
refactor: Refactor FPE masks in Examples
Oct 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #2581 +/- ##
=======================================
Coverage 49.63% 49.63%
=======================================
Files 471 471
Lines 26690 26690
Branches 12278 12278
=======================================
Hits 13247 13247
Misses 4748 4748
Partials 8695 8695
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions
bot
added
Component - Core
Affects the Core module
Vertexing
Track Fitting
labels
Oct 27, 2023
paulgessinger
approved these changes
Oct 28, 2023
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Oct 28, 2023
paulgessinger
removed
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Core
Affects the Core module
Infrastructure
Changes to build tools, continous integration, ...
Track Fitting
Vertexing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently mixing where we set masks and some of them are not accurate anymore. Here I try to reduce the masks to a minimum and set them in the code when appropriate.
blocked by: