-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: GX2F: add additional parameters to python bindings #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Track Fitting
labels
Oct 26, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
==========================================
- Coverage 49.56% 49.56% -0.01%
==========================================
Files 474 474
Lines 26928 26930 +2
Branches 12422 12423 +1
==========================================
Hits 13348 13348
+ Misses 4751 4748 -3
- Partials 8829 8834 +5 ☔ View full report in Codecov by Sentry. |
paulgessinger
changed the title
[BLOCKED] refactor: GX2F: add additional parameters to python bindings
refactor: GX2F: add additional parameters to python bindings
Oct 27, 2023
This reverts commit 238fc50.
I guess this is not blocked anymore @AJPfleger ? can you fix the clang tidy stuff? |
andiwand
added
👷♀️ User Action Needed
and removed
🛑 blocked
This item is blocked by another item
labels
Nov 20, 2023
This reverts commit ab8e680.
andiwand
approved these changes
Nov 21, 2023
acts-project-service
added
Breaks Athena build
This PR breaks the Athena build
Fails Athena tests
This PR causes a failure in the Athena tests
labels
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaks Athena build
This PR breaks the Athena build
Component - Core
Affects the Core module
Component - Examples
Affects the Examples module
Fails Athena tests
This PR causes a failure in the Athena tests
Track Fitting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more parameters to the python bindings of the Global Chi Square Filter:
blocked by:
relChi2changeCutOff
#2586