Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: GX2F: add additional parameters to python bindings #2584

Merged
merged 19 commits into from
Nov 21, 2023

Conversation

AJPfleger
Copy link
Contributor

@AJPfleger AJPfleger commented Oct 26, 2023

Adds more parameters to the python bindings of the Global Chi Square Filter:

  /// Max number of iterations during the fit (abort condition)
  size_t nUpdateMax = 5;

  /// Disables the QoP fit in case of missing B-field
  bool zeroField = false;

  /// Check for convergence (abort condition). Set to 0 to skip.
  double relChi2changeCutOff = 1e-7;

blocked by:

@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Track Fitting labels Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (1d8d3ec) 49.56% compared to head (cf190df) 49.56%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ore/include/Acts/Propagator/MaterialInteractor.hpp 47.16% 10 Missing and 18 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2584      +/-   ##
==========================================
- Coverage   49.56%   49.56%   -0.01%     
==========================================
  Files         474      474              
  Lines       26928    26930       +2     
  Branches    12422    12423       +1     
==========================================
  Hits        13348    13348              
+ Misses       4751     4748       -3     
- Partials     8829     8834       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulgessinger paulgessinger changed the title [BLOCKED] refactor: GX2F: add additional parameters to python bindings refactor: GX2F: add additional parameters to python bindings Oct 27, 2023
@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Oct 27, 2023
@paulgessinger paulgessinger added this to the v31.0.0 milestone Nov 16, 2023
This reverts commit 238fc50.
@andiwand
Copy link
Contributor

I guess this is not blocked anymore @AJPfleger ?

can you fix the clang tidy stuff?

@andiwand andiwand added 👷‍♀️ User Action Needed and removed 🛑 blocked This item is blocked by another item labels Nov 20, 2023
@kodiakhq kodiakhq bot merged commit 3d1dc45 into acts-project:main Nov 21, 2023
49 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Nov 21, 2023

@acts-project-service acts-project-service added Breaks Athena build This PR breaks the Athena build Fails Athena tests This PR causes a failure in the Athena tests labels Nov 21, 2023
@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants