feat: GX2F: abort condition relChi2changeCutOff
#2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2586 +/- ##
=======================================
Coverage 49.60% 49.61%
=======================================
Files 473 473
Lines 26833 26844 +11
Branches 12357 12362 +5
=======================================
+ Hits 13311 13319 +8
Misses 4753 4753
- Partials 8769 8772 +3
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
paulgessinger
changed the title
relChi2changeCutOffrelChi2changeCutOff
paulgessinger
approved these changes
Nov 10, 2023
paulgessinger
approved these changes
Nov 10, 2023
acts-project-service
added
the
Fails Athena tests
paulgessinger
removed
the
Fails Athena tests
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Adds more parameters to the python bindings of the Global Chi Square Filter: ``` /// Max number of iterations during the fit (abort condition) size_t nUpdateMax = 5; /// Disables the QoP fit in case of missing B-field bool zeroField = false; /// Check for convergence (abort condition). Set to 0 to skip. double relChi2changeCutOff = 1e-7; ``` blocked by: - #2574 - #2586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new abort condition for the Global Chi Square Fitter:
relChi2changeCutOff.Before we could only steer with
nUpdateMaxwhen to stop to iterate.This relative cut-off checks if the
chi2sumalready converged.blocked by: