Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Delegate construction with tag type #2668

Merged
merged 9 commits into from
Nov 15, 2023

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Nov 14, 2023

This uses an empty tag struct to add constructors from free and member function pointers. The member function pointer constructor right now only supports non-owning delegates.

This also fixes a potential memory leak when moving a unique_ptr into a non-owning delegate. I don't think this was used anywhere, however.

benjaminhuth
benjaminhuth previously approved these changes Nov 14, 2023
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-actions github-actions bot added the Component - Core Affects the Core module label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bd74d01) 49.72% compared to head (668d2a0) 49.73%.

Files Patch % Lines
Core/include/Acts/Utilities/Delegate.hpp 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2668   +/-   ##
=======================================
  Coverage   49.72%   49.73%           
=======================================
  Files         474      474           
  Lines       26870    26875    +5     
  Branches    12365    12365           
=======================================
+ Hits        13361    13366    +5     
  Misses       4705     4705           
  Partials     8804     8804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should we mention the fixed memory leak in the PR description?

@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 15, 2023
@kodiakhq kodiakhq bot merged commit 1db9cee into acts-project:main Nov 15, 2023
54 checks passed
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants