-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Delegate construction with tag type #2668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
=======================================
Coverage 49.72% 49.73%
=======================================
Files 474 474
Lines 26870 26875 +5
Branches 12365 12365
=======================================
+ Hits 13361 13366 +5
Misses 4705 4705
Partials 8804 8804 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Should we mention the fixed memory leak in the PR description?
This uses an empty tag struct to add constructors from free and member function pointers. The member function pointer constructor right now only supports non-owning delegates.
This also fixes a potential memory leak when moving a unique_ptr into a non-owning delegate. I don't think this was used anywhere, however.