Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Seed CSV Writing #2690

Merged
merged 14 commits into from
Nov 24, 2023
Merged

Conversation

Corentin-Allaire
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire commented Nov 17, 2023

This PR add a CSV writing mechanism for seed, those can then be used later to train ML based seed filter (once implemented). It also add the seed id to the stored information in the CSV track writing and a python based script that allowed us to matched the best reconstructed track with the corresponding seed.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1c697c) 49.50% compared to head (bfe7b15) 49.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2690   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         475      475           
  Lines       26975    26975           
  Branches    12454    12454           
=======================================
  Hits        13355    13355           
  Misses       4762     4762           
  Partials     8858     8858           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andiwand andiwand added this to the next milestone Nov 24, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kodiakhq kodiakhq bot merged commit 51828bd into acts-project:main Nov 24, 2023
53 checks passed
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
kodiakhq bot pushed a commit that referenced this pull request Dec 14, 2023
This pull request add a ML based seed selection that can be used to reduce the number of seed after the seeding step.
This PR is pending on the merging of #2690.
LaraCalic pushed a commit to LaraCalic/acts that referenced this pull request Feb 10, 2024
This pull request add a ML based seed selection that can be used to reduce the number of seed after the seeding step.
This PR is pending on the merging of acts-project#2690.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants