-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Seed CSV Writing #2690
Merged
Merged
feat: Seed CSV Writing #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Examples
Affects the Examples module
Ambiguity Resolution
labels
Nov 17, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2690 +/- ##
=======================================
Coverage 49.50% 49.50%
=======================================
Files 475 475
Lines 26975 26975
Branches 12454 12454
=======================================
Hits 13355 13355
Misses 4762 4762
Partials 8858 8858 ☔ View full report in Codecov by Sentry. |
andiwand
reviewed
Nov 20, 2023
Examples/Scripts/Python/MLAmbiguityResolution/match_good_track-seed.py
Outdated
Show resolved
Hide resolved
Examples/Scripts/Python/MLAmbiguityResolution/match_good_track-seed.py
Outdated
Show resolved
Hide resolved
Examples/Scripts/Python/MLAmbiguityResolution/match_good_track-seed.py
Outdated
Show resolved
Hide resolved
Renaming Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
andiwand
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
This pull request add a ML based seed selection that can be used to reduce the number of seed after the seeding step. This PR is pending on the merging of #2690.
LaraCalic
pushed a commit
to LaraCalic/acts
that referenced
this pull request
Feb 10, 2024
This pull request add a ML based seed selection that can be used to reduce the number of seed after the seeding step. This PR is pending on the merging of acts-project#2690.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a CSV writing mechanism for seed, those can then be used later to train ML based seed filter (once implemented). It also add the seed id to the stored information in the CSV track writing and a python based script that allowed us to matched the best reconstructed track with the corresponding seed.